2022-07-09 00:05:52

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message

Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")'
changed the log level of the write boost enable/disable notification
from debug to info, this results in a lot of noise in the kernel log
during normal operation.

Drop it back to debug level to avoid this.

Fixes: 3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 22042ee3af14..be65d5bf123e 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5747,7 +5747,7 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable)
}

hba->dev_info.wb_enabled = enable;
- dev_info(hba->dev, "%s Write Booster %s\n",
+ dev_dbg(hba->dev, "%s Write Booster %s\n",
__func__, enable ? "enabled" : "disabled");

return ret;
--
2.35.1


2022-07-09 10:18:54

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message



>-----Original Message-----
>From: Bjorn Andersson [mailto:[email protected]]
>Sent: Saturday, July 9, 2022 5:30 AM
>To: Alim Akhtar <[email protected]>; Avri Altman
><[email protected]>; Bart Van Assche <[email protected]>; James
>E.J. Bottomley <[email protected]>; Martin K. Petersen
><[email protected]>
>Cc: Bean Huo <[email protected]>; Adrian Hunter
><[email protected]>; Yue Hu <[email protected]>; linux-
>[email protected]; [email protected]
>Subject: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
>
>Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")'
>changed the log level of the write boost enable/disable notification from
>debug to info, this results in a lot of noise in the kernel log during
normal
>operation.
>
>Drop it back to debug level to avoid this.
>
>Fixes: 3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")
>Signed-off-by: Bjorn Andersson <[email protected]>
>---

Reviewed-by: Alim Akhtar <[email protected]>

> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
>22042ee3af14..be65d5bf123e 100644
>--- a/drivers/ufs/core/ufshcd.c
>+++ b/drivers/ufs/core/ufshcd.c
>@@ -5747,7 +5747,7 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool
>enable)
> }
>
> hba->dev_info.wb_enabled = enable;
>- dev_info(hba->dev, "%s Write Booster %s\n",
>+ dev_dbg(hba->dev, "%s Write Booster %s\n",
> __func__, enable ? "enabled" : "disabled");
>
> return ret;
>--
>2.35.1


2022-07-10 21:27:02

by Bean Huo

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message

On Fri, 2022-07-08 at 17:00 -0700, Bjorn Andersson wrote:
> Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration
> code")'
> changed the log level of the write boost enable/disable notification
> from debug to info, this results in a lot of noise in the kernel log
> during normal operation.
>
> Drop it back to debug level to avoid this.
>
> Fixes: 3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration
> code")
> Signed-off-by: Bjorn Andersson <[email protected]>
>
Acked-by: Bean Huo <[email protected]>

2022-07-14 05:00:17

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message

On Fri, 8 Jul 2022 17:00:27 -0700, Bjorn Andersson wrote:

> Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")'
> changed the log level of the write boost enable/disable notification
> from debug to info, this results in a lot of noise in the kernel log
> during normal operation.
>
> Drop it back to debug level to avoid this.
>
> [...]

Applied to 5.19/scsi-fixes, thanks!

[1/1] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
https://git.kernel.org/mkp/scsi/c/2ae57c995003

--
Martin K. Petersen Oracle Linux Engineering