2020-05-03 15:23:48

by Michał Mirosław

[permalink] [raw]
Subject: [PATCH v2 01/11] power: bq25890: remove redundant I2C bus check

regmap initialization will check I2C adapter functionality.
Remove redundant check in the driver.

Signed-off-by: Michał Mirosław <[email protected]>
---
drivers/power/supply/bq25890_charger.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
index aebd1253dbc9..c642519ef7b2 100644
--- a/drivers/power/supply/bq25890_charger.c
+++ b/drivers/power/supply/bq25890_charger.c
@@ -881,17 +881,11 @@ static int bq25890_fw_probe(struct bq25890_device *bq)
static int bq25890_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
- struct i2c_adapter *adapter = client->adapter;
struct device *dev = &client->dev;
struct bq25890_device *bq;
int ret;
int i;

- if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
- dev_err(dev, "No support for SMBUS_BYTE_DATA\n");
- return -ENODEV;
- }
-
bq = devm_kzalloc(dev, sizeof(*bq), GFP_KERNEL);
if (!bq)
return -ENOMEM;
--
2.20.1


2020-05-03 20:00:46

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH v2 01/11] power: bq25890: remove redundant I2C bus check

Hi,

On Sun, May 03, 2020 at 05:21:10PM +0200, Michał Mirosław wrote:
> regmap initialization will check I2C adapter functionality.
> Remove redundant check in the driver.
>
> Signed-off-by: Michał Mirosław <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/bq25890_charger.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index aebd1253dbc9..c642519ef7b2 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -881,17 +881,11 @@ static int bq25890_fw_probe(struct bq25890_device *bq)
> static int bq25890_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> - struct i2c_adapter *adapter = client->adapter;
> struct device *dev = &client->dev;
> struct bq25890_device *bq;
> int ret;
> int i;
>
> - if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
> - dev_err(dev, "No support for SMBUS_BYTE_DATA\n");
> - return -ENODEV;
> - }
> -
> bq = devm_kzalloc(dev, sizeof(*bq), GFP_KERNEL);
> if (!bq)
> return -ENOMEM;
> --
> 2.20.1
>

Attachments:
(No filename) (1.20 kB)
 signature.asc (849.00 B)
 Download all attachments