2023-07-26 20:42:12

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: Add bindings for peci-npcm


On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote:
> From: Tomer Maimon <[email protected]>
>
> Add device tree bindings for the peci-npcm controller driver.
>
> Signed-off-by: Tomer Maimon <[email protected]>
> Signed-off-by: Tyrone Ting <[email protected]>
> Co-developed-by: Iwona Winiarska <[email protected]>
> Signed-off-by: Iwona Winiarska <[email protected]>
> ---
> Changes v1 -> v2:
>
> * Renamed binding filename to match compatible (Krzysztof)
> ---
> .../bindings/peci/nuvoton,npcm-peci.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
$id: http://devicetree.org/schemas/peci/peci-npcm.yaml
file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



2023-07-26 21:46:00

by Winiarska, Iwona

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: Add bindings for peci-npcm

On Wed, 2023-07-26 at 14:14 -0600, Rob Herring wrote:
>
> On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote:
> > From: Tomer Maimon <[email protected]>
> >
> > Add device tree bindings for the peci-npcm controller driver.
> >
> > Signed-off-by: Tomer Maimon <[email protected]>
> > Signed-off-by: Tyrone Ting <[email protected]>
> > Co-developed-by: Iwona Winiarska <[email protected]>
> > Signed-off-by: Iwona Winiarska <[email protected]>
> > ---
> > Changes v1 -> v2:
> >
> > * Renamed binding filename to match compatible (Krzysztof)
> > ---
> >  .../bindings/peci/nuvoton,npcm-peci.yaml      | 56 +++++++++++++++++++
> >  1 file changed, 56 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm-
> > peci.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id:
> Cannot determine base path from $id, relative path/filename doesn't match
> actual path or filename
>          $id: http://devicetree.org/schemas/peci/peci-npcm.yaml
>         file: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml

Oops, sorry about that - I'll send v3.

Thanks
-Iwona

>
> doc reference errors (make refcheckdocs):
>
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>