2023-03-22 17:03:31

by Miquel Raynal

Subject: [PATCH v2 1/4] nvmem: Add macro to register nvmem layout drivers

Provide a module_nvmem_layout_driver() macro at the end of the
nvmem-provider.h header to reduce the boilerplate when registering nvmem
layout drivers.

Suggested-by: Srinivas Kandagatla <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
---
include/linux/nvmem-provider.h | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 0cf9f9490514..3e97c8315c45 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -9,6 +9,7 @@
#ifndef _LINUX_NVMEM_PROVIDER_H
#define _LINUX_NVMEM_PROVIDER_H

+#include <linux/device/driver.h>
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/gpio/consumer.h>
@@ -240,4 +241,9 @@ nvmem_layout_get_match_data(struct nvmem_device *nvmem,
}

#endif /* CONFIG_NVMEM */
+
+#define module_nvmem_layout_driver(__layout_driver) \
+ module_driver(__layout_driver, nvmem_layout_register, \
+ nvmem_layout_unregister)
+
#endif /* ifndef _LINUX_NVMEM_PROVIDER_H */
--
2.34.1

2023-03-22 17:12:23

by Rafał Miłecki

Subject: Re: [PATCH v2 1/4] nvmem: Add macro to register nvmem layout drivers

On 2023-03-22 17:58, Miquel Raynal wrote:
> Provide a module_nvmem_layout_driver() macro at the end of the
> nvmem-provider.h header to reduce the boilerplate when registering
> nvmem
> layout drivers.
>
> Suggested-by: Srinivas Kandagatla <[email protected]>
> Signed-off-by: Miquel Raynal <[email protected]>

Acked-by: Rafał Miłecki <[email protected]>

> ---
> include/linux/nvmem-provider.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/nvmem-provider.h
> b/include/linux/nvmem-provider.h
> index 0cf9f9490514..3e97c8315c45 100644
> --- a/include/linux/nvmem-provider.h
> +++ b/include/linux/nvmem-provider.h
> @@ -9,6 +9,7 @@
> #ifndef _LINUX_NVMEM_PROVIDER_H
> #define _LINUX_NVMEM_PROVIDER_H
>
> +#include <linux/device/driver.h>
> #include <linux/err.h>
> #include <linux/errno.h>
> #include <linux/gpio/consumer.h>
> @@ -240,4 +241,9 @@ nvmem_layout_get_match_data(struct nvmem_device
> *nvmem,
> }
>
> #endif /* CONFIG_NVMEM */
> +
> +#define module_nvmem_layout_driver(__layout_driver) \
> + module_driver(__layout_driver, nvmem_layout_register, \
> + nvmem_layout_unregister)
> +
> #endif /* ifndef _LINUX_NVMEM_PROVIDER_H */