2021-06-17 20:28:33

by Andy Shevchenko

Subject: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)

Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP, the latter
is going to be removed from clock framework.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/platform/x86/intel-int3472/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel-int3472/Kconfig b/drivers/platform/x86/intel-int3472/Kconfig
index c112878e833b..62e5d4cf9ee5 100644
--- a/drivers/platform/x86/intel-int3472/Kconfig
+++ b/drivers/platform/x86/intel-int3472/Kconfig
@@ -1,7 +1,7 @@
config INTEL_SKL_INT3472
tristate "Intel SkyLake ACPI INT3472 Driver"
depends on ACPI
- depends on COMMON_CLK && CLKDEV_LOOKUP
+ depends on COMMON_CLK
depends on I2C
depends on GPIOLIB
depends on REGULATOR
--
2.30.2

2021-06-18 04:49:56

by Daniel Scally

Subject: Re: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)

Hi Andy

On 17/06/2021 19:30, Andy Shevchenko wrote:
> Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP


So it does - thanks

> , the latter
> is going to be removed from clock framework.
>
> Signed-off-by: Andy Shevchenko <[email protected]>


Reviewed-by: Daniel Scally <[email protected]>

> ---
> drivers/platform/x86/intel-int3472/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel-int3472/Kconfig b/drivers/platform/x86/intel-int3472/Kconfig
> index c112878e833b..62e5d4cf9ee5 100644
> --- a/drivers/platform/x86/intel-int3472/Kconfig
> +++ b/drivers/platform/x86/intel-int3472/Kconfig
> @@ -1,7 +1,7 @@
> config INTEL_SKL_INT3472
> tristate "Intel SkyLake ACPI INT3472 Driver"
> depends on ACPI
> - depends on COMMON_CLK && CLKDEV_LOOKUP
> + depends on COMMON_CLK
> depends on I2C
> depends on GPIOLIB
> depends on REGULATOR

2021-06-18 16:07:56

by Andy Shevchenko

Subject: Re: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)

On Thu, Jun 17, 2021 at 11:50:36PM +0100, Daniel Scally wrote:
> Hi Andy
>
> On 17/06/2021 19:30, Andy Shevchenko wrote:
> > Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP
>
>
> So it does - thanks
>
> > , the latter
> > is going to be removed from clock framework.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
>
> Reviewed-by: Daniel Scally <[email protected]>

Thanks!
I have sent v2 with more patches added (twice bigger than this).
Would you be able to test them?

--
With Best Regards,
Andy Shevchenko

2021-06-18 16:08:15

by Daniel Scally

Subject: Re: [PATCH v1 2/4] platform/x86: intel_skl_int3472: Fix dependencies (drop CLKDEV_LOOKUP)

Hi Andy

On 18/06/2021 13:56, Andy Shevchenko wrote:
> On Thu, Jun 17, 2021 at 11:50:36PM +0100, Daniel Scally wrote:
>> Hi Andy
>>
>> On 17/06/2021 19:30, Andy Shevchenko wrote:
>>> Besides the fact that COMMON_CLK selects CLKDEV_LOOKUP
>>
>> So it does - thanks
>>
>>> , the latter
>>> is going to be removed from clock framework.
>>>
>>> Signed-off-by: Andy Shevchenko <[email protected]>
>>
>> Reviewed-by: Daniel Scally <[email protected]>
> Thanks!
> I have sent v2 with more patches added (twice bigger than this).
> Would you be able to test them?
>
Sure - I'll test them later tonight - thanks!