2024-06-03 19:59:41

by Jeff Johnson

[permalink] [raw]
Subject: [PATCH] misc: fastrpc: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/misc/fastrpc.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/misc/fastrpc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 4c67e2c5a82e..e040cb5470c4 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -2478,5 +2478,6 @@ static void fastrpc_exit(void)
}
module_exit(fastrpc_exit);

+MODULE_DESCRIPTION("Qualcomm FastRPC");
MODULE_LICENSE("GPL v2");
MODULE_IMPORT_NS(DMA_BUF);

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240603-md-misc-fastrpc-b644f497e68e



2024-06-03 22:58:46

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH] misc: fastrpc: add missing MODULE_DESCRIPTION() macro

On 03/06/2024 20:58, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/misc/fastrpc.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/misc/fastrpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 4c67e2c5a82e..e040cb5470c4 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -2478,5 +2478,6 @@ static void fastrpc_exit(void)
> }
> module_exit(fastrpc_exit);
>
> +MODULE_DESCRIPTION("Qualcomm FastRPC");
> MODULE_LICENSE("GPL v2");
> MODULE_IMPORT_NS(DMA_BUF);
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240603-md-misc-fastrpc-b644f497e68e
>
>
Reviewed-by: Bryan O'Donoghue <[email protected]>

2024-06-04 12:35:25

by Caleb Connolly

[permalink] [raw]
Subject: Re: [PATCH] misc: fastrpc: add missing MODULE_DESCRIPTION() macro



On 03/06/2024 21:58, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/misc/fastrpc.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Reviewed-by; Caleb Connolly <[email protected]>
> ---
> drivers/misc/fastrpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 4c67e2c5a82e..e040cb5470c4 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -2478,5 +2478,6 @@ static void fastrpc_exit(void)
> }
> module_exit(fastrpc_exit);
>
> +MODULE_DESCRIPTION("Qualcomm FastRPC");
> MODULE_LICENSE("GPL v2");
> MODULE_IMPORT_NS(DMA_BUF);
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240603-md-misc-fastrpc-b644f497e68e
>
>

--
// Caleb (they/them)

2024-06-11 12:00:35

by Srinivas Kandagatla

[permalink] [raw]
Subject: Re: (subset) [PATCH] misc: fastrpc: add missing MODULE_DESCRIPTION() macro


On Mon, 03 Jun 2024 12:58:08 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/misc/fastrpc.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
>

Applied, thanks!

[1/1] misc: fastrpc: add missing MODULE_DESCRIPTION() macro
commit: 6814f03445b30f6a136ff043cb54c0a86e3de982

Best regards,
--
Srinivas Kandagatla <[email protected]>