2022-06-23 10:25:28

by Jiang Jian

Subject: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments

there is an unexpected word 'for' in the comments that need to be dropped

file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
line - 3

* Test cases for for the DRM DP MST helpers

changed to:

* Test cases for the DRM DP MST helpers

Signed-off-by: Jiang Jian <[email protected]>
---
drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
index 967c52150b67..4caa9be900ac 100644
--- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
+++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Test cases for for the DRM DP MST helpers
+ * Test cases for the DRM DP MST helpers
*/

#define PREFIX_STR "[drm_dp_mst_helper]"
--
2.17.1

2022-06-28 21:51:35

by Lyude Paul

Subject: Re: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments

…ah, I totally forgot that gitlab happens to be down right now which part of
the DRM maintainer scripts rely on - so I can't actually push this patch
upstream right away. I will set this email as unread so hopefully I don't lose
track of this, but please feel free to ping me if I do end up forgetting.

On Tue, 2022-06-28 at 17:32 -0400, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <[email protected]>
>
> Going to change the name of the patch slightly so it's more obvious this is
> just about the MST selftests
>
> On Thu, 2022-06-23 at 18:06 +0800, Jiang Jian wrote:
> > there is an unexpected word 'for' in the comments that need to be dropped
> >
> > file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > line - 3
> >
> > * Test cases for for the DRM DP MST helpers
> >
> > changed to:
> >
> > * Test cases for the DRM DP MST helpers
> >
> > Signed-off-by: Jiang Jian <[email protected]>
> > ---
> >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > index 967c52150b67..4caa9be900ac 100644
> > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > @@ -1,6 +1,6 @@
> >  // SPDX-License-Identifier: GPL-2.0-only
> >  /*
> > - * Test cases for for the DRM DP MST helpers
> > + * Test cases for the DRM DP MST helpers
> >   */
> >  
> >  #define PREFIX_STR "[drm_dp_mst_helper]"
>

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat

2022-06-28 22:11:16

by Lyude Paul

Subject: Re: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments

Reviewed-by: Lyude Paul <[email protected]>

Going to change the name of the patch slightly so it's more obvious this is
just about the MST selftests

On Thu, 2022-06-23 at 18:06 +0800, Jiang Jian wrote:
> there is an unexpected word 'for' in the comments that need to be dropped
>
> file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> line - 3
>
> * Test cases for for the DRM DP MST helpers
>
> changed to:
>
> * Test cases for the DRM DP MST helpers
>
> Signed-off-by: Jiang Jian <[email protected]>
> ---
>  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> index 967c52150b67..4caa9be900ac 100644
> --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * Test cases for for the DRM DP MST helpers
> + * Test cases for the DRM DP MST helpers
>   */
>  
>  #define PREFIX_STR "[drm_dp_mst_helper]"

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat

2022-06-28 23:36:12

by Lyude Paul

Subject: Re: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments

Oh-it's back up now! will push now :)

On Tue, 2022-06-28 at 17:35 -0400, Lyude Paul wrote:
> …ah, I totally forgot that gitlab happens to be down right now which part of
> the DRM maintainer scripts rely on - so I can't actually push this patch
> upstream right away. I will set this email as unread so hopefully I don't
> lose
> track of this, but please feel free to ping me if I do end up forgetting.
>
> On Tue, 2022-06-28 at 17:32 -0400, Lyude Paul wrote:
> > Reviewed-by: Lyude Paul <[email protected]>
> >
> > Going to change the name of the patch slightly so it's more obvious this
> > is
> > just about the MST selftests
> >
> > On Thu, 2022-06-23 at 18:06 +0800, Jiang Jian wrote:
> > > there is an unexpected word 'for' in the comments that need to be
> > > dropped
> > >
> > > file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > line - 3
> > >
> > > * Test cases for for the DRM DP MST helpers
> > >
> > > changed to:
> > >
> > > * Test cases for the DRM DP MST helpers
> > >
> > > Signed-off-by: Jiang Jian <[email protected]>
> > > ---
> > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > index 967c52150b67..4caa9be900ac 100644
> > > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > @@ -1,6 +1,6 @@
> > >  // SPDX-License-Identifier: GPL-2.0-only
> > >  /*
> > > - * Test cases for for the DRM DP MST helpers
> > > + * Test cases for the DRM DP MST helpers
> > >   */
> > >  
> > >  #define PREFIX_STR "[drm_dp_mst_helper]"
> >
>

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat