From: Randy Dunlap <[email protected]>
Fix sparse warning: (missing '=')
../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Cc: Jonas Rabenstein <[email protected]>
Cc: David Kozub <[email protected]>
---
block/sed-opal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-54-rc1.orig/block/sed-opal.c
+++ lnx-54-rc1/block/sed-opal.c
@@ -129,7 +129,7 @@ static const u8 opaluid[][OPAL_UID_LENGT
{ 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x84, 0x01 },
/* tables */
- [OPAL_TABLE_TABLE]
+ [OPAL_TABLE_TABLE] =
{ 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01 },
[OPAL_LOCKINGRANGE_GLOBAL] =
{ 0x00, 0x00, 0x08, 0x02, 0x00, 0x00, 0x00, 0x01 },
On 10/3/2019 9:42 AM, Scott Bauer wrote:
> On Wed, Oct 02, 2019 at 07:23:05PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <[email protected]>
>>
>> Fix sparse warning: (missing '=')
>> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
>>
>> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Jens Axboe <[email protected]>
>> Cc: [email protected]
>> Cc: Jonas Rabenstein <[email protected]>
>> Cc: David Kozub <[email protected]>
>> ---
> Un cc'd David and Jonas, +CC'd Jon and Revanth.
>
> This looks fine to me too.
>
> Reviewed-by: Scott Bauer <[email protected]>
Looks fine to me as well
Reviewed-by: Revanth Rajashekar <[email protected]>
On 10/3/2019 9:42 AM, Scott Bauer wrote:
> On Wed, Oct 02, 2019 at 07:23:05PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <[email protected]>
>>
>> Fix sparse warning: (missing '=')
>> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
>>
>> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Jens Axboe <[email protected]>
>> Cc: [email protected]
>> Cc: Jonas Rabenstein <[email protected]>
>> Cc: David Kozub <[email protected]>
>> ---
> Un cc'd David and Jonas, +CC'd Jon and Revanth.
>
> This looks fine to me too.
>
> Reviewed-by: Scott Bauer <[email protected]>
the patch set looks fine for me
Reviewed-by: Revanth Rajashekar <[email protected]>
On Wed, 2019-10-02 at 19:23 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix sparse warning: (missing '=')
> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
>
> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: [email protected]
> Cc: Jonas Rabenstein <[email protected]>
> Cc: David Kozub <[email protected]>
> ---
> block/sed-opal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-54-rc1.orig/block/sed-opal.c
> +++ lnx-54-rc1/block/sed-opal.c
> @@ -129,7 +129,7 @@ static const u8 opaluid[][OPAL_UID_LENGT
> { 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x84, 0x01 },
>
> /* tables */
> - [OPAL_TABLE_TABLE]
> + [OPAL_TABLE_TABLE] =
> { 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01 },
> [OPAL_LOCKINGRANGE_GLOBAL] =
> { 0x00, 0x00, 0x08, 0x02, 0x00, 0x00, 0x00, 0x01 },
>
Reviewed-by: Jon Derrick <[email protected]>
On Wed, Oct 02, 2019 at 07:23:05PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix sparse warning: (missing '=')
> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
>
> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: [email protected]
> Cc: Jonas Rabenstein <[email protected]>
> Cc: David Kozub <[email protected]>
> ---
Un cc'd David and Jonas, +CC'd Jon and Revanth.
This looks fine to me too.
Reviewed-by: Scott Bauer <[email protected]>
On 10/2/19 8:23 PM, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix sparse warning: (missing '=')
> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
Applied this (and 2/2, no cover letter...), thanks Randy.
--
Jens Axboe