LinuxLists.cc - [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings

2017-09-26 07:24:47

Subject: [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings

Hello

The goal of this patch series is to have a clean DT build with W=1.

Regards

Changes since v1:
- moved i2c2 unit address change from patch #2 in patch #1

Changes since v2
- added two patch for fixing pin names

Corentin Labbe (14):
ARM: dts: sunxi: h3/h5: Fix simple-bus unit address format error
ARM: dts: sunxi: h3/h5: Fix i2c2 register address
ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property
ARM: dts: nanopi: Fix node with unit name and no reg property
ARM: dts: orangepi2: Fix node with unit name and no reg property
ARM: dts: sun8i: orangepi-lite: Fix node with unit name and no reg
property
ARM: dts: sun8i: orangepi one: Fix node with unit name and no reg
property
ARM: dts: sun8i: orangepipc: Fix node with unit name and no reg
property
ARM: dts: sun8i: orangepi-plus: Fix node with unit name and no reg
property
arm64: allwinner: a64: Fix simple-bus unit address format error
arm64: allwinner: a64: Fix node with unit name and no reg property
ARM: dts: sun8i: a83t: Fix simple-bus unit address format error
arm64: allwinner: a64: fix pin name
ARM: dts: sun8i: fix pin name

arch/arm/boot/dts/sun8i-a83t.dtsi | 6 +-
arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 8 +-
arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 8 +-
arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 10 +--
arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 4 +-
arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 2 +-
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts | 4 +-
arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 12 +--
arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 16 ++--
arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 14 ++--
arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 10 +--
arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 2 +-
arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 12 +--
arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +-
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 88 +++++++++++-----------
.../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +-
.../boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 2 +-
.../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 2 +-
.../boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 2 +-
.../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 2 +-
.../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +-
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 +++----
.../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 6 +-
.../boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 4 +-
.../boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts | 6 +-
.../dts/allwinner/sun50i-h5-orangepi-prime.dts | 8 +-
.../allwinner/sun50i-h5-orangepi-zero-plus2.dts | 4 +-
27 files changed, 132 insertions(+), 132 deletions(-)

--
2.13.5

2017-09-26 07:28:46

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 01/14] ARM: dts: sunxi: h3/h5: Fix simple-bus unit address format error

This patch remove leading 0 of unit address and so remove
lots of warning when building DT with W=1.

Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Maxime Ripard <[email protected]>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 74 +++++++++++++++++++-------------------
1 file changed, 37 insertions(+), 37 deletions(-)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index a8e9b8f378ba..b37ed3461229 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -91,7 +91,7 @@
reg = <0x01c00000 0x1000>;
};

- dma: dma-controller@01c02000 {
+ dma: dma-controller@1c02000 {
compatible = "allwinner,sun8i-h3-dma";
reg = <0x01c02000 0x1000>;
interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
@@ -100,7 +100,7 @@
#dma-cells = <1>;
};

- mmc0: mmc@01c0f000 {
+ mmc0: mmc@1c0f000 {
/* compatible and clocks are in per SoC .dtsi file */
reg = <0x01c0f000 0x1000>;
resets = <&ccu RST_BUS_MMC0>;
@@ -111,7 +111,7 @@
#size-cells = <0>;
};

- mmc1: mmc@01c10000 {
+ mmc1: mmc@1c10000 {
/* compatible and clocks are in per SoC .dtsi file */
reg = <0x01c10000 0x1000>;
resets = <&ccu RST_BUS_MMC1>;
@@ -122,7 +122,7 @@
#size-cells = <0>;
};

- mmc2: mmc@01c11000 {
+ mmc2: mmc@1c11000 {
/* compatible and clocks are in per SoC .dtsi file */
reg = <0x01c11000 0x1000>;
resets = <&ccu RST_BUS_MMC2>;
@@ -133,7 +133,7 @@
#size-cells = <0>;
};

- usb_otg: usb@01c19000 {
+ usb_otg: usb@1c19000 {
compatible = "allwinner,sun8i-h3-musb";
reg = <0x01c19000 0x400>;
clocks = <&ccu CLK_BUS_OTG>;
@@ -158,7 +158,7 @@
status = "disabled";
};

- usbphy: phy@01c19400 {
+ usbphy: phy@1c19400 {
compatible = "allwinner,sun8i-h3-usb-phy";
reg = <0x01c19400 0x2c>,
<0x01c1a800 0x4>,
@@ -190,7 +190,7 @@
#phy-cells = <1>;
};

- ehci0: usb@01c1a000 {
+ ehci0: usb@1c1a000 {
compatible = "allwinner,sun8i-h3-ehci", "generic-ehci";
reg = <0x01c1a000 0x100>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
@@ -199,7 +199,7 @@
status = "disabled";
};

- ohci0: usb@01c1a400 {
+ ohci0: usb@1c1a400 {
compatible = "allwinner,sun8i-h3-ohci", "generic-ohci";
reg = <0x01c1a400 0x100>;
interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
@@ -209,7 +209,7 @@
status = "disabled";
};

- ehci1: usb@01c1b000 {
+ ehci1: usb@1c1b000 {
compatible = "allwinner,sun8i-h3-ehci", "generic-ehci";
reg = <0x01c1b000 0x100>;
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
@@ -220,7 +220,7 @@
status = "disabled";
};

- ohci1: usb@01c1b400 {
+ ohci1: usb@1c1b400 {
compatible = "allwinner,sun8i-h3-ohci", "generic-ohci";
reg = <0x01c1b400 0x100>;
interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
@@ -232,7 +232,7 @@
status = "disabled";
};

- ehci2: usb@01c1c000 {
+ ehci2: usb@1c1c000 {
compatible = "allwinner,sun8i-h3-ehci", "generic-ehci";
reg = <0x01c1c000 0x100>;
interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
@@ -243,7 +243,7 @@
status = "disabled";
};

- ohci2: usb@01c1c400 {
+ ohci2: usb@1c1c400 {
compatible = "allwinner,sun8i-h3-ohci", "generic-ohci";
reg = <0x01c1c400 0x100>;
interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
@@ -255,7 +255,7 @@
status = "disabled";
};

- ehci3: usb@01c1d000 {
+ ehci3: usb@1c1d000 {
compatible = "allwinner,sun8i-h3-ehci", "generic-ehci";
reg = <0x01c1d000 0x100>;
interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
@@ -266,7 +266,7 @@
status = "disabled";
};

- ohci3: usb@01c1d400 {
+ ohci3: usb@1c1d400 {
compatible = "allwinner,sun8i-h3-ohci", "generic-ohci";
reg = <0x01c1d400 0x100>;
interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
@@ -278,7 +278,7 @@
status = "disabled";
};

- ccu: clock@01c20000 {
+ ccu: clock@1c20000 {
/* compatible is in per SoC .dtsi file */
reg = <0x01c20000 0x400>;
clocks = <&osc24M>, <&osc32k>;
@@ -287,7 +287,7 @@
#reset-cells = <1>;
};

- pio: pinctrl@01c20800 {
+ pio: pinctrl@1c20800 {
/* compatible is in per SoC .dtsi file */
reg = <0x01c20800 0x400>;
interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
@@ -400,7 +400,7 @@
};
};

- timer@01c20c00 {
+ timer@1c20c00 {
compatible = "allwinner,sun4i-a10-timer";
reg = <0x01c20c00 0xa0>;
interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
@@ -453,7 +453,7 @@
};
};

- spi0: spi@01c68000 {
+ spi0: spi@1c68000 {
compatible = "allwinner,sun8i-h3-spi";
reg = <0x01c68000 0x1000>;
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
@@ -469,7 +469,7 @@
#size-cells = <0>;
};

- spi1: spi@01c69000 {
+ spi1: spi@1c69000 {
compatible = "allwinner,sun8i-h3-spi";
reg = <0x01c69000 0x1000>;
interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
@@ -485,13 +485,13 @@
#size-cells = <0>;
};

- wdt0: watchdog@01c20ca0 {
+ wdt0: watchdog@1c20ca0 {
compatible = "allwinner,sun6i-a31-wdt";
reg = <0x01c20ca0 0x20>;
interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
};

- spdif: spdif@01c21000 {
+ spdif: spdif@1c21000 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-spdif";
reg = <0x01c21000 0x400>;
@@ -504,7 +504,7 @@
status = "disabled";
};

- pwm: pwm@01c21400 {
+ pwm: pwm@1c21400 {
compatible = "allwinner,sun8i-h3-pwm";
reg = <0x01c21400 0x8>;
clocks = <&osc24M>;
@@ -512,7 +512,7 @@
status = "disabled";
};

- i2s0: i2s@01c22000 {
+ i2s0: i2s@1c22000 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-i2s";
reg = <0x01c22000 0x400>;
@@ -525,7 +525,7 @@
status = "disabled";
};

- i2s1: i2s@01c22400 {
+ i2s1: i2s@1c22400 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-i2s";
reg = <0x01c22400 0x400>;
@@ -538,7 +538,7 @@
status = "disabled";
};

- codec: codec@01c22c00 {
+ codec: codec@1c22c00 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-codec";
reg = <0x01c22c00 0x400>;
@@ -552,7 +552,7 @@
status = "disabled";
};

- uart0: serial@01c28000 {
+ uart0: serial@1c28000 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28000 0x400>;
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
@@ -565,7 +565,7 @@
status = "disabled";
};

- uart1: serial@01c28400 {
+ uart1: serial@1c28400 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28400 0x400>;
interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
@@ -578,7 +578,7 @@
status = "disabled";
};

- uart2: serial@01c28800 {
+ uart2: serial@1c28800 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28800 0x400>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
@@ -591,7 +591,7 @@
status = "disabled";
};

- uart3: serial@01c28c00 {
+ uart3: serial@1c28c00 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28c00 0x400>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
@@ -604,7 +604,7 @@
status = "disabled";
};

- i2c0: i2c@01c2ac00 {
+ i2c0: i2c@1c2ac00 {
compatible = "allwinner,sun6i-a31-i2c";
reg = <0x01c2ac00 0x400>;
interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
@@ -617,7 +617,7 @@
#size-cells = <0>;
};

- i2c1: i2c@01c2b000 {
+ i2c1: i2c@1c2b000 {
compatible = "allwinner,sun6i-a31-i2c";
reg = <0x01c2b000 0x400>;
interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
@@ -630,7 +630,7 @@
#size-cells = <0>;
};

- i2c2: i2c@01c2b400 {
+ i2c2: i2c@1c2b400 {
compatible = "allwinner,sun6i-a31-i2c";
reg = <0x01c2b000 0x400>;
interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
@@ -643,7 +643,7 @@
#size-cells = <0>;
};

- gic: interrupt-controller@01c81000 {
+ gic: interrupt-controller@1c81000 {
compatible = "arm,gic-400";
reg = <0x01c81000 0x1000>,
<0x01c82000 0x2000>,
@@ -654,7 +654,7 @@
interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
};

- rtc: rtc@01f00000 {
+ rtc: rtc@1f00000 {
compatible = "allwinner,sun6i-a31-rtc";
reg = <0x01f00000 0x54>;
interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
@@ -671,12 +671,12 @@
#reset-cells = <1>;
};

- codec_analog: codec-analog@01f015c0 {
+ codec_analog: codec-analog@1f015c0 {
compatible = "allwinner,sun8i-h3-codec-analog";
reg = <0x01f015c0 0x4>;
};

- ir: ir@01f02000 {
+ ir: ir@1f02000 {
compatible = "allwinner,sun5i-a13-ir";
clocks = <&r_ccu CLK_APB0_IR>, <&r_ccu CLK_IR>;
clock-names = "apb", "ir";
@@ -686,7 +686,7 @@
status = "disabled";
};

- r_pio: pinctrl@01f02c00 {
+ r_pio: pinctrl@1f02c00 {
compatible = "allwinner,sun8i-h3-r-pinctrl";
reg = <0x01f02c00 0x400>;
interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
--
2.13.5

2017-09-26 07:28:30

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 02/14] ARM: dts: sunxi: h3/h5: Fix i2c2 register address

The unit address and register address does not match.
This patch fix the register address with the good one.

Acked-by: Maxime Ripard <[email protected]>
Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index b37ed3461229..289f2cd06dfe 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -632,7 +632,7 @@

i2c2: i2c@1c2b400 {
compatible = "allwinner,sun6i-a31-i2c";
- reg = <0x01c2b000 0x400>;
+ reg = <0x01c2b400 0x400>;
interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&ccu CLK_BUS_I2C2>;
resets = <&ccu RST_BUS_I2C2>;
--
2.13.5

2017-09-26 07:24:52

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 03/14] ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property

This patch fix the warning "xxx has a unit name, but no reg property" by
removing "@0" from such node.

Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Maxime Ripard <[email protected]>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 289f2cd06dfe..2e4bae988acd 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -322,7 +322,7 @@
function = "i2c2";
};

- mmc0_pins_a: mmc0@0 {
+ mmc0_pins_a: mmc0 {
pins = "PF0", "PF1", "PF2", "PF3",
"PF4", "PF5";
function = "mmc0";
@@ -330,13 +330,13 @@
bias-pull-up;
};

- mmc0_cd_pin: mmc0_cd_pin@0 {
+ mmc0_cd_pin: mmc0_cd_pin {
pins = "PF6";
function = "gpio_in";
bias-pull-up;
};

- mmc1_pins_a: mmc1@0 {
+ mmc1_pins_a: mmc1 {
pins = "PG0", "PG1", "PG2", "PG3",
"PG4", "PG5";
function = "mmc1";
@@ -354,7 +354,7 @@
bias-pull-up;
};

- spdif_tx_pins_a: spdif@0 {
+ spdif_tx_pins_a: spdif {
pins = "PA17";
function = "spdif";
};
@@ -369,7 +369,7 @@
function = "spi1";
};

- uart0_pins_a: uart0@0 {
+ uart0_pins_a: uart0 {
pins = "PA4", "PA5";
function = "uart0";
};
@@ -697,7 +697,7 @@
interrupt-controller;
#interrupt-cells = <3>;

- ir_pins_a: ir@0 {
+ ir_pins_a: ir {
pins = "PL11";
function = "s_cir_rx";
};
--
2.13.5

2017-09-26 07:24:54

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 04/14] ARM: dts: nanopi: Fix node with unit name and no reg property

This patch fix the warning "xxx has a unit name, but no reg property" by
removing "@0" from such node.

Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Maxime Ripard <[email protected]>
---
arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi b/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
index c6decee41a27..7646e331bd29 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
@@ -81,7 +81,7 @@
pinctrl-names = "default";
pinctrl-0 = <&sw_r_npi>;

- k1@0 {
+ k1 {
label = "k1";
linux,code = <KEY_POWER>;
gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
@@ -108,19 +108,19 @@
};

&pio {
- leds_npi: led_pins@0 {
+ leds_npi: led_pins {
pins = "PA10";
function = "gpio_out";
};
};

&r_pio {
- leds_r_npi: led_pins@0 {
+ leds_r_npi: led_pins {
pins = "PL10";
function = "gpio_out";
};

- sw_r_npi: key_pins@0 {
+ sw_r_npi: key_pins {
pins = "PL3";
function = "gpio_in";
};
--
2.13.5

2017-09-26 07:24:58

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 05/14] ARM: dts: orangepi2: Fix node with unit name and no reg property

This patch fix the warning "xxx has a unit name, but no reg property" by
removing "@0" from such node.

Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Maxime Ripard <[email protected]>
---
arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
index 17cdeae19c6f..b20be95b49d5 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
@@ -160,24 +160,24 @@
};

&pio {
- leds_opc: led_pins@0 {
+ leds_opc: led_pins {
pins = "PA15";
function = "gpio_out";
};
};

&r_pio {
- leds_r_opc: led_pins@0 {
+ leds_r_opc: led_pins {
pins = "PL10";
function = "gpio_out";
};

- sw_r_opc: key_pins@0 {
+ sw_r_opc: key_pins {
pins = "PL3", "PL4";
function = "gpio_in";
};

- wifi_pwrseq_pin_orangepi: wifi_pwrseq_pin@0 {
+ wifi_pwrseq_pin_orangepi: wifi_pwrseq_pin {
pins = "PL7";
function = "gpio_out";
};
--
2.13.5

2017-09-26 07:28:10

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 06/14] ARM: dts: sun8i: orangepi-lite: Fix node with unit name and no reg property

2017-09-26 07:27:49

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 07/14] ARM: dts: sun8i: orangepi one: Fix node with unit name and no reg property

2017-09-26 07:26:56

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 08/14] ARM: dts: sun8i: orangepipc: Fix node with unit name and no reg property

2017-09-26 07:26:21

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 09/14] ARM: dts: sun8i: orangepi-plus: Fix node with unit name and no reg property

2017-09-26 07:26:19

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 10/14] arm64: allwinner: a64: Fix simple-bus unit address format error

2017-09-26 07:26:04

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 11/14] arm64: allwinner: a64: Fix node with unit name and no reg property

This patch fix the warning "xxx has a unit name, but no reg property" by
removing "@0" from such node

Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Maxime Ripard <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 662e8b7981b5..b02a8476b0c8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -347,7 +347,7 @@
function = "spi1";
};

- uart0_pins_a: uart0@0 {
+ uart0_pins_a: uart0 {
pins = "PB8", "PB9";
function = "uart0";
};
@@ -571,7 +571,7 @@
interrupt-controller;
#interrupt-cells = <3>;

- r_rsb_pins: rsb@0 {
+ r_rsb_pins: rsb {
pins = "PL0", "PL1";
function = "s_rsb";
};
--
2.13.5

2017-09-26 07:25:09

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 12/14] ARM: dts: sun8i: a83t: Fix simple-bus unit address format error

This patch remove leading 0 of unit address and so remove
lots of warning when building DT with W=1.

Signed-off-by: Corentin Labbe <[email protected]>
Acked-by: Maxime Ripard <[email protected]>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 7f99ef37f61f..dd6a393725c6 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -248,7 +248,7 @@
status = "disabled";
};

- usb_otg: usb@01c19000 {
+ usb_otg: usb@1c19000 {
compatible = "allwinner,sun8i-a83t-musb",
"allwinner,sun8i-a33-musb";
reg = <0x01c19000 0x0400>;
@@ -436,7 +436,7 @@
status = "disabled";
};

- uart0: serial@01c28000 {
+ uart0: serial@1c28000 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28000 0x400>;
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
@@ -447,7 +447,7 @@
status = "disabled";
};

- uart1: serial@01c28400 {
+ uart1: serial@1c28400 {
compatible = "snps,dw-apb-uart";
reg = <0x01c28400 0x400>;
interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
--
2.13.5

2017-09-26 07:25:14

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 13/14] arm64: allwinner: a64: fix pin name

2017-09-26 07:25:47

by Corentin Labbe

[permalink] [raw]

Subject: [PATCH v3 14/14] ARM: dts: sun8i: fix pin name

All pinmux nodes should have the suffix "_pins" or "_pin".

In the case where there are multiple choices, the node name should convey
what or which pingroup the choice is.

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 8 ++++----
arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 8 ++++----
arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 10 +++++-----
arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 4 ++--
arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 2 +-
arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts | 4 ++--
arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 4 ++--
arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 ++++----
arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 8 ++++----
arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 4 ++--
arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 2 +-
arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 6 +++---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 10 +++++-----
arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 6 +++---
arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 4 ++--
arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts | 6 +++---
arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-prime.dts | 8 ++++----
.../arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 4 ++--
18 files changed, 53 insertions(+), 53 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
index 6713d0f2b3f4..8b1e2dace4da 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
@@ -113,7 +113,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>;
+ pinctrl-0 = <&mmc0_pf_pins>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -123,7 +123,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc_wifi>;
mmc-pwrseq = <&wifi_pwrseq>;
bus-width = <4>;
@@ -139,7 +139,7 @@
};
};

-&mmc1_pins_a {
+&mmc1_pins {
bias-pull-up;
};

@@ -166,7 +166,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
index cc20d676a642..575510a5fd01 100644
--- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
@@ -125,7 +125,7 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

@@ -138,7 +138,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -148,7 +148,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
vqmmc-supply = <&reg_vcc3v3>;
mmc-pwrseq = <&wifi_pwrseq>;
@@ -194,7 +194,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
index 10da56e86ab8..2631a3619dc4 100644
--- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
@@ -110,13 +110,13 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -126,7 +126,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
non-removable;
@@ -166,13 +166,13 @@

&spdif {
pinctrl-names = "default";
- pinctrl-0 = <&spdif_tx_pins_a>;
+ pinctrl-0 = <&spdif_pin>;
status = "okay";
};

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
index 818f9bf5df66..7beb10c6940c 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
@@ -91,7 +91,7 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

@@ -104,7 +104,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
vqmmc-supply = <&reg_vcc3v3>;
mmc-pwrseq = <&wifi_pwrseq>;
diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index 3a2ccdb28afd..08f3577c9b0a 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -57,7 +57,7 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
index 03ff6f8b93ff..a9d4d0b01439 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
@@ -76,7 +76,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -86,7 +86,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi b/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
index 7646e331bd29..ca63c383d4ed 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi.dtsi
@@ -98,7 +98,7 @@
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
cd-inverted;
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
status = "okay";
vmmc-supply = <&reg_vcc3v3>;
};
@@ -128,7 +128,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
index b20be95b49d5..6845fbcc306b 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts
@@ -127,13 +127,13 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -143,7 +143,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
mmc-pwrseq = <&wifi_pwrseq>;
bus-width = <4>;
@@ -190,7 +190,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts
index a70a1daf4e2c..cebf0f0c84c4 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts
@@ -101,13 +101,13 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -117,7 +117,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
non-removable;
@@ -161,7 +161,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
index 82e5d28cd698..cf6d273992f7 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
@@ -107,7 +107,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -149,7 +149,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
index a10281b455f5..2307f750293a 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
@@ -60,7 +60,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
non-removable;
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
index 6d98bcfbe877..76e8fbd22c38 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
@@ -127,13 +127,13 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
@@ -183,7 +183,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 2e4bae988acd..f9d6411f4b39 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -322,7 +322,7 @@
function = "i2c2";
};

- mmc0_pins_a: mmc0 {
+ mmc0_pf_pins: mmc0 {
pins = "PF0", "PF1", "PF2", "PF3",
"PF4", "PF5";
function = "mmc0";
@@ -336,7 +336,7 @@
bias-pull-up;
};

- mmc1_pins_a: mmc1 {
+ mmc1_pins: mmc1 {
pins = "PG0", "PG1", "PG2", "PG3",
"PG4", "PG5";
function = "mmc1";
@@ -354,7 +354,7 @@
bias-pull-up;
};

- spdif_tx_pins_a: spdif {
+ spdif_pin: spdif {
pins = "PA17";
function = "spdif";
};
@@ -369,7 +369,7 @@
function = "spi1";
};

- uart0_pins_a: uart0 {
+ uart0_pb_pins: uart0 {
pins = "PA4", "PA5";
function = "uart0";
};
@@ -697,7 +697,7 @@
interrupt-controller;
#interrupt-cells = <3>;

- ir_pins_a: ir {
+ ir_pin: ir {
pins = "PL11";
function = "s_cir_rx";
};
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
index 7c028af58f47..3b242136306c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
@@ -135,7 +135,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
@@ -144,7 +144,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
vqmmc-supply = <&reg_vcc3v3>;
mmc-pwrseq = <&wifi_pwrseq>;
@@ -178,7 +178,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
index 968908761194..eafa116b1c18 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
@@ -127,7 +127,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
@@ -144,7 +144,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
index a8296feee884..3e028b18d703 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
@@ -148,7 +148,7 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

@@ -161,7 +161,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
@@ -186,7 +186,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-prime.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-prime.dts
index d906b302cbcd..bb9554fe7389 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-prime.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-prime.dts
@@ -155,7 +155,7 @@

&ir {
pinctrl-names = "default";
- pinctrl-0 = <&ir_pins_a>;
+ pinctrl-0 = <&ir_pin>;
status = "okay";
};

@@ -168,7 +168,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
@@ -177,7 +177,7 @@

&mmc1 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc1_pins_a>;
+ pinctrl-0 = <&mmc1_pins>;
vmmc-supply = <&reg_vcc3v3>;
mmc-pwrseq = <&wifi_pwrseq>;
bus-width = <4>;
@@ -203,7 +203,7 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
index b6b7a561df8c..71c9b05e1740 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
@@ -68,7 +68,7 @@

&mmc0 {
pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
+ pinctrl-0 = <&mmc0_pf_pins>, <&mmc0_cd_pin>;
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
@@ -87,6 +87,6 @@

&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};
--
2.13.5

2017-09-26 07:46:41

by Chen-Yu Tsai

[permalink] [raw]

Subject: Re: [PATCH v3 13/14] arm64: allwinner: a64: fix pin name

On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
<[email protected]> wrote:
> All pinmux nodes should have the suffix "_pins" or "_pin".
>
> In the case where there are multiple choices, the node name should convey
> what or which pingroup the choice is.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +-
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 +++---
> 7 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index 45bdbfb96126..36a56e3ab92f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -248,7 +248,7 @@
>
> &uart0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&uart0_pins_a>;
> + pinctrl-0 = <&uart0_pb_pins>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> index 2beef9e6cb88..15019edb7dd6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> @@ -198,7 +198,7 @@
>
> &uart0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&uart0_pins_a>;
> + pinctrl-0 = <&uart0_pb_pins>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> index 338e786155b1..ec62c86cc236 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> @@ -194,6 +194,6 @@
>
> &uart0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&uart0_pins_a>;
> + pinctrl-0 = <&uart0_pb_pins>;
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> index 5f8ff4017d45..1c8b9d2721f0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> @@ -85,7 +85,7 @@
>
> &uart0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&uart0_pins_a>;
> + pinctrl-0 = <&uart0_pb_pins>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> index 806442d3e846..69743ff171d0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> @@ -232,7 +232,7 @@
> /* On Exp and Euler connectors */
> &uart0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&uart0_pins_a>;
> + pinctrl-0 = <&uart0_pb_pins>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index 0eb2acedf8c3..e41eb71eb438 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -135,7 +135,7 @@
>
> &uart0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&uart0_pins_a>;
> + pinctrl-0 = <&uart0_pb_pins>;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index b02a8476b0c8..2d2937b7dc68 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -347,7 +347,7 @@
> function = "spi1";
> };
>
> - uart0_pins_a: uart0 {
> + uart0_pb_pins: uart0 {

You are again confusing node names with node labels.
And it doesn't match what your commit message says.

The node name is what never changes even when the device
tree is compiled into a binary blob. The label gets compiled
out, and any references to it are converted to an integer
index, much like how a goto label in C gets compiled.

Of the two, the node name is what I asked to be changed.
Please take a look at arch/arm/boot/dts/sun8i-a83t.dtsi
for a proper example of what I am asking for. Note that
node names should use hyphens, not underscores, while
labels should use underscores. For the pinmux nodes
the name and label would likely be the same except for
this exception. So your uart0 label changes are good.
Please keep them.

> pins = "PB8", "PB9";
> function = "uart0";
> };
> @@ -571,7 +571,7 @@
> interrupt-controller;
> #interrupt-cells = <3>;
>
> - r_rsb_pins: rsb {
> + rsb_pins: rsb {

I'm not sure why you changed this label. It doesn't make sense.

> pins = "PL0", "PL1";
> function = "s_rsb";
> };
> @@ -585,7 +585,7 @@
> clock-frequency = <3000000>;
> resets = <&r_ccu 2>;
> pinctrl-names = "default";
> - pinctrl-0 = <&r_rsb_pins>;
> + pinctrl-0 = <&rsb_pins>;
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.13.5
>

2017-09-26 07:48:45

by Chen-Yu Tsai

[permalink] [raw]

Subject: Re: [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings

On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
<[email protected]> wrote:
> Hello
>
> The goal of this patch series is to have a clean DT build with W=1.
>
> Regards
>
> Changes since v1:
> - moved i2c2 unit address change from patch #2 in patch #1
>
> Changes since v2
> - added two patch for fixing pin names

The first twelve patches are good. Maxime, I think we can go ahead and
merge them, instead of having them resent again in v3?

The last two patches are not what I asked for though.

ChenYu

2017-09-26 07:55:36

by Corentin Labbe

[permalink] [raw]

Subject: Re: [PATCH v3 13/14] arm64: allwinner: a64: fix pin name

On Tue, Sep 26, 2017 at 03:46:13PM +0800, Chen-Yu Tsai wrote:
> On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
> <[email protected]> wrote:
> > All pinmux nodes should have the suffix "_pins" or "_pin".
> >
> > In the case where there are multiple choices, the node name should convey
> > what or which pingroup the choice is.
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 6 +++---
> > 7 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> > index 45bdbfb96126..36a56e3ab92f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> > @@ -248,7 +248,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> > index 2beef9e6cb88..15019edb7dd6 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
> > @@ -198,7 +198,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > index 338e786155b1..ec62c86cc236 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -194,6 +194,6 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> > index 5f8ff4017d45..1c8b9d2721f0 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-orangepi-win.dts
> > @@ -85,7 +85,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > index 806442d3e846..69743ff171d0 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > @@ -232,7 +232,7 @@
> > /* On Exp and Euler connectors */
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > index 0eb2acedf8c3..e41eb71eb438 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > @@ -135,7 +135,7 @@
> >
> > &uart0 {
> > pinctrl-names = "default";
> > - pinctrl-0 = <&uart0_pins_a>;
> > + pinctrl-0 = <&uart0_pb_pins>;
> > status = "okay";
> > };
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index b02a8476b0c8..2d2937b7dc68 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -347,7 +347,7 @@
> > function = "spi1";
> > };
> >
> > - uart0_pins_a: uart0 {
> > + uart0_pb_pins: uart0 {
>
> You are again confusing node names with node labels.
> And it doesn't match what your commit message says.
>
> The node name is what never changes even when the device
> tree is compiled into a binary blob. The label gets compiled
> out, and any references to it are converted to an integer
> index, much like how a goto label in C gets compiled.
>
> Of the two, the node name is what I asked to be changed.
> Please take a look at arch/arm/boot/dts/sun8i-a83t.dtsi
> for a proper example of what I am asking for. Note that
> node names should use hyphens, not underscores, while
> labels should use underscores. For the pinmux nodes
> the name and label would likely be the same except for
> this exception. So your uart0 label changes are good.
> Please keep them.
>

Sorry, I misunderstood your query.

I will fix that.

Regards
Corentin Labbe

2017-09-26 08:58:59

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings

On Tue, Sep 26, 2017 at 07:48:17AM +0000, Chen-Yu Tsai wrote:
> On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
> <[email protected]> wrote:
> > Hello
> >
> > The goal of this patch series is to have a clean DT build with W=1.
> >
> > Regards
> >
> > Changes since v1:
> > - moved i2c2 unit address change from patch #2 in patch #1
> >
> > Changes since v2
> > - added two patch for fixing pin names
>
> The first twelve patches are good. Maxime, I think we can go ahead and
> merge them, instead of having them resent again in v3?

Yep, that works for me. Can you push them?

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:

(No filename) (700.00 B)
signature.asc (801.00 B)
Download all attachments

2017-09-26 13:01:56

by Chen-Yu Tsai

[permalink] [raw]

Subject: Re: [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings

On Tue, Sep 26, 2017 at 4:58 PM, Maxime Ripard
<[email protected]> wrote:
> On Tue, Sep 26, 2017 at 07:48:17AM +0000, Chen-Yu Tsai wrote:
>> On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
>> <[email protected]> wrote:
>> > Hello
>> >
>> > The goal of this patch series is to have a clean DT build with W=1.
>> >
>> > Regards
>> >
>> > Changes since v1:
>> > - moved i2c2 unit address change from patch #2 in patch #1
>> >
>> > Changes since v2
>> > - added two patch for fixing pin names
>>
>> The first twelve patches are good. Maxime, I think we can go ahead and
>> merge them, instead of having them resent again in v3?
>
> Yep, that works for me. Can you push them?

Patches 1 and 12 didn't apply cleanly. I fixed them.

Patches 4~9 do the same type of cleanup for various h3 board dts files.
Maybe we should just squash them together. Arnd seems to prefer squashing
identical changes to different boards together.

ChenYu

2017-09-27 15:18:42

by Chen-Yu Tsai

[permalink] [raw]

Subject: Re: [PATCH v3 00/14] ARM: dts: sunxi: Fix DT build warnings

On Tue, Sep 26, 2017 at 9:01 PM, Chen-Yu Tsai <[email protected]> wrote:
> On Tue, Sep 26, 2017 at 4:58 PM, Maxime Ripard
> <[email protected]> wrote:
>> On Tue, Sep 26, 2017 at 07:48:17AM +0000, Chen-Yu Tsai wrote:
>>> On Tue, Sep 26, 2017 at 3:22 PM, Corentin Labbe
>>> <[email protected]> wrote:
>>> > Hello
>>> >
>>> > The goal of this patch series is to have a clean DT build with W=1.
>>> >
>>> > Regards
>>> >
>>> > Changes since v1:
>>> > - moved i2c2 unit address change from patch #2 in patch #1
>>> >
>>> > Changes since v2
>>> > - added two patch for fixing pin names
>>>
>>> The first twelve patches are good. Maxime, I think we can go ahead and
>>> merge them, instead of having them resent again in v3?
>>
>> Yep, that works for me. Can you push them?
>
> Patches 1 and 12 didn't apply cleanly. I fixed them.

Patch 10 didn't apply cleanly either. I fixed it.

> Patches 4~9 do the same type of cleanup for various h3 board dts files.
> Maybe we should just squash them together. Arnd seems to prefer squashing
> identical changes to different boards together.

Squashed them and mentioned it in the commit message.

Please check the sunxi tree on git.kernel.org if the results are correct.

ChenYu

2018-08-01 13:13:44

by Icenowy Zheng

[permalink] [raw]

Subject: Re: [PATCH v3 02/14] ARM: dts: sunxi: h3/h5: Fix i2c2 register address

在 2017-09-26二的 09:22 +0200，Corentin Labbe写道：
> The unit address and register address does not match.
> This patch fix the register address with the good one.
>
> Acked-by: Maxime Ripard <[email protected]>
> Signed-off-by: Corentin Labbe <[email protected]>

This patch should be backported.

Older LTS also needs patches, but the patch needs to be refactored to
suite the versions.

Cc: [email protected] # 4.14

> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index b37ed3461229..289f2cd06dfe 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -632,7 +632,7 @@
>
> i2c2: i2c@1c2b400 {
> compatible = "allwinner,sun6i-a31-i2c";
> - reg = <0x01c2b000 0x400>;
> + reg = <0x01c2b400 0x400>;
> interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&ccu CLK_BUS_I2C2>;
> resets = <&ccu RST_BUS_I2C2>;