2024-04-24 08:51:28

by Hongbo Li

Subject: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed

When prepare_ondemand_read failed, wrong error message is printed.
The prepare_read is also implemented in cachefiles, so we amend it.

Reviewed-by: Gao Xiang <[email protected]>
Signed-off-by: Hongbo Li <[email protected]>
---
fs/erofs/fscache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 8aff1a724805..62da538d91cb 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
if (WARN_ON(len == 0))
source = NETFS_INVALID_READ;
if (source != NETFS_READ_FROM_CACHE) {
- erofs_err(NULL, "prepare_read failed (source %d)", source);
+ erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
return -EIO;
}

--
2.34.1

2024-04-24 11:22:10

by Jingbo Xu

Subject: Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed

On 4/24/24 4:42 PM, Hongbo Li wrote:
> When prepare_ondemand_read failed, wrong error message is printed.
> The prepare_read is also implemented in cachefiles, so we amend it.
>
> Reviewed-by: Gao Xiang <[email protected]>
> Signed-off-by: Hongbo Li <[email protected]>
> ---
> fs/erofs/fscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
> index 8aff1a724805..62da538d91cb 100644
> --- a/fs/erofs/fscache.c
> +++ b/fs/erofs/fscache.c
> @@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct fscache_cookie *cookie,
> if (WARN_ON(len == 0))
> source = NETFS_INVALID_READ;
> if (source != NETFS_READ_FROM_CACHE) {
> - erofs_err(NULL, "prepare_read failed (source %d)", source);
> + erofs_err(NULL, "prepare_ondemand_read failed (source %d)", source);
> return -EIO;
> }
>


LGTM.

Reviewed-by: Jingbo Xu <[email protected]>

--
Thanks,
Jingbo

2024-04-28 06:23:20

by Chao Yu

Subject: Re: [PATCH -next] erofs: modify the error message when prepare_ondemand_read failed

On 2024/4/24 16:42, Hongbo Li wrote:
> When prepare_ondemand_read failed, wrong error message is printed.
> The prepare_read is also implemented in cachefiles, so we amend it.
>
> Reviewed-by: Gao Xiang <[email protected]>
> Signed-off-by: Hongbo Li <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,