2022-11-15 03:15:59

by Li zeming

Subject: [PATCH] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer

The packet pointer is assigned first. It does not need to initialize the
assignment.

Signed-off-by: Li zeming <[email protected]>
---
net/sctp/sm_statefuns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index f6ee7f4040c1..714605746fee 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -3781,7 +3781,7 @@ static enum sctp_disposition sctp_sf_shut_8_4_5(
void *arg,
struct sctp_cmd_seq *commands)
{
- struct sctp_packet *packet = NULL;
+ struct sctp_packet *packet;
struct sctp_chunk *chunk = arg;
struct sctp_chunk *shut;

--
2.18.2

2022-11-17 12:29:08

by Paolo Abeni

Subject: Re: [PATCH] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer

Hi,

On Tue, 2022-11-15 at 09:55 +0800, Li zeming wrote:
> The packet pointer is assigned first. It does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <[email protected]>

I'm sorry, but IMHO the commit message is quite unclear, I suggest to
re-phrase to something alike:

"""
The 'packet' pointer is always set in the later code, no need to
initialize it at definition time.
"""

Thanks,

Paolo

2022-11-18 02:10:29

by Li zeming

Subject:

Many thanks. I resubmit a patch.