2020-04-16 00:06:44

by Yue Haibing

Subject: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'

drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=]
static const struct venc_config venc_config_pal_bdghi = {
^~~~~~~~~~~~~~~~~~~~~

It is never used, remove it.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/omapdrm/dss/venc.c | 43 ------------------------------
1 file changed, 43 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
index 766553bb2f87..9701843ccf09 100644
--- a/drivers/gpu/drm/omapdrm/dss/venc.c
+++ b/drivers/gpu/drm/omapdrm/dss/venc.c
@@ -208,49 +208,6 @@ static const struct venc_config venc_config_ntsc_trm = {
.gen_ctrl = 0x00F90000,
};

-static const struct venc_config venc_config_pal_bdghi = {
- .f_control = 0,
- .vidout_ctrl = 0,
- .sync_ctrl = 0,
- .hfltr_ctrl = 0,
- .x_color = 0,
- .line21 = 0,
- .ln_sel = 21,
- .htrigger_vtrigger = 0,
- .tvdetgp_int_start_stop_x = 0x00140001,
- .tvdetgp_int_start_stop_y = 0x00010001,
- .gen_ctrl = 0x00FB0000,
-
- .llen = 864-1,
- .flens = 625-1,
- .cc_carr_wss_carr = 0x2F7625ED,
- .c_phase = 0xDF,
- .gain_u = 0x111,
- .gain_v = 0x181,
- .gain_y = 0x140,
- .black_level = 0x3e,
- .blank_level = 0x3e,
- .m_control = 0<<2 | 1<<1,
- .bstamp_wss_data = 0x42,
- .s_carr = 0x2a098acb,
- .l21__wc_ctl = 0<<13 | 0x16<<8 | 0<<0,
- .savid__eavid = 0x06A70108,
- .flen__fal = 23<<16 | 624<<0,
- .lal__phase_reset = 2<<17 | 310<<0,
- .hs_int_start_stop_x = 0x00920358,
- .hs_ext_start_stop_x = 0x000F035F,
- .vs_int_start_x = 0x1a7<<16,
- .vs_int_stop_x__vs_int_start_y = 0x000601A7,
- .vs_int_stop_y__vs_ext_start_x = 0x01AF0036,
- .vs_ext_stop_x__vs_ext_start_y = 0x27101af,
- .vs_ext_stop_y = 0x05,
- .avid_start_stop_x = 0x03530082,
- .avid_start_stop_y = 0x0270002E,
- .fid_int_start_x__fid_int_start_y = 0x0005008A,
- .fid_int_offset_y__fid_ext_start_x = 0x002E0138,
- .fid_ext_start_y__fid_ext_offset_y = 0x01380005,
-};
-
enum venc_videomode {
VENC_MODE_UNKNOWN,
VENC_MODE_PAL,
--
2.17.1

2020-04-16 00:17:23

by Laurent Pinchart

Subject: Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'

Hi Yue,

Thank you for the patch.

On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote:
> drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
> warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=]
> static const struct venc_config venc_config_pal_bdghi = {
> ^~~~~~~~~~~~~~~~~~~~~
>
> It is never used, remove it.

Tomi, is this the right fix, or should we work on making use of this
structure ?

> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/omapdrm/dss/venc.c | 43 ------------------------------
> 1 file changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
> index 766553bb2f87..9701843ccf09 100644
> --- a/drivers/gpu/drm/omapdrm/dss/venc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/venc.c
> @@ -208,49 +208,6 @@ static const struct venc_config venc_config_ntsc_trm = {
> .gen_ctrl = 0x00F90000,
> };
>
> -static const struct venc_config venc_config_pal_bdghi = {
> - .f_control = 0,
> - .vidout_ctrl = 0,
> - .sync_ctrl = 0,
> - .hfltr_ctrl = 0,
> - .x_color = 0,
> - .line21 = 0,
> - .ln_sel = 21,
> - .htrigger_vtrigger = 0,
> - .tvdetgp_int_start_stop_x = 0x00140001,
> - .tvdetgp_int_start_stop_y = 0x00010001,
> - .gen_ctrl = 0x00FB0000,
> -
> - .llen = 864-1,
> - .flens = 625-1,
> - .cc_carr_wss_carr = 0x2F7625ED,
> - .c_phase = 0xDF,
> - .gain_u = 0x111,
> - .gain_v = 0x181,
> - .gain_y = 0x140,
> - .black_level = 0x3e,
> - .blank_level = 0x3e,
> - .m_control = 0<<2 | 1<<1,
> - .bstamp_wss_data = 0x42,
> - .s_carr = 0x2a098acb,
> - .l21__wc_ctl = 0<<13 | 0x16<<8 | 0<<0,
> - .savid__eavid = 0x06A70108,
> - .flen__fal = 23<<16 | 624<<0,
> - .lal__phase_reset = 2<<17 | 310<<0,
> - .hs_int_start_stop_x = 0x00920358,
> - .hs_ext_start_stop_x = 0x000F035F,
> - .vs_int_start_x = 0x1a7<<16,
> - .vs_int_stop_x__vs_int_start_y = 0x000601A7,
> - .vs_int_stop_y__vs_ext_start_x = 0x01AF0036,
> - .vs_ext_stop_x__vs_ext_start_y = 0x27101af,
> - .vs_ext_stop_y = 0x05,
> - .avid_start_stop_x = 0x03530082,
> - .avid_start_stop_y = 0x0270002E,
> - .fid_int_start_x__fid_int_start_y = 0x0005008A,
> - .fid_int_offset_y__fid_ext_start_x = 0x002E0138,
> - .fid_ext_start_y__fid_ext_offset_y = 0x01380005,
> -};
> -
> enum venc_videomode {
> VENC_MODE_UNKNOWN,
> VENC_MODE_PAL,

--
Regards,

Laurent Pinchart

2020-04-16 06:34:09

by Tomi Valkeinen

Subject: Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'

On 15/04/2020 18:39, Laurent Pinchart wrote:
> Hi Yue,
>
> Thank you for the patch.
>
> On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote:
>> drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
>> warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=]
>> static const struct venc_config venc_config_pal_bdghi = {
>> ^~~~~~~~~~~~~~~~~~~~~
>>
>> It is never used, remove it.
>
> Tomi, is this the right fix, or should we work on making use of this
> structure ?

I think we can remove it. I'll pick you this patch.

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki