2023-02-10 02:14:58

by Thomas Weißschuh

Subject: [PATCH] zonefs: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
fs/zonefs/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/zonefs/sysfs.c b/fs/zonefs/sysfs.c
index 9920689dc098..8ccb65c2b419 100644
--- a/fs/zonefs/sysfs.c
+++ b/fs/zonefs/sysfs.c
@@ -79,7 +79,7 @@ static const struct sysfs_ops zonefs_sysfs_attr_ops = {
.show = zonefs_sysfs_attr_show,
};

-static struct kobj_type zonefs_sb_ktype = {
+static const struct kobj_type zonefs_sb_ktype = {
.default_groups = zonefs_sysfs_groups,
.sysfs_ops = &zonefs_sysfs_attr_ops,
.release = zonefs_sysfs_sb_release,

---
base-commit: e544a07438522ab3688416e6e2e34bf0ee6d8755
change-id: 20230210-kobj_type-zonefs-a124912033b3

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-10 11:37:22

by Johannes Thumshirn

Subject: Re: [PATCH] zonefs: make kobj_type structure constant

Looks good,
Reviewed-by: Johannes Thumshirn <[email protected]>

2023-02-12 23:10:45

by Damien Le Moal

Subject: Re: [PATCH] zonefs: make kobj_type structure constant

On 2/10/23 11:14, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>

Applied to for-6.3. Thanks !

--
Damien Le Moal
Western Digital Research