2022-10-26 20:08:23

by Krzysztof Kozlowski

Subject: [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards

SDHCI on SM8450 HDK also has problems with SDR104/SDR50:

mmc0: card never left busy state
mmc0: error -110 whilst initialising SD card

so I think it is safe to assume this issue affects all SM8450 boards.
Move the quirk disallowing these modes to the SoC DTSI, to spare people
working on other boards the misery of debugging this issue.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
index 718c690af8ad..ae8ba297b0b6 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
@@ -556,8 +556,6 @@ &sdhc_2 {
pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
vmmc-supply = <&pm8350c_l9>;
vqmmc-supply = <&pm8350c_l6>;
- /* Forbid SDR104/SDR50 - broken hw! */
- sdhci-caps-mask = <0x3 0x0>;
no-sdio;
no-mmc;
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 1df5c964c6f7..6800e05a549d 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3412,6 +3412,9 @@ sdhc_2: sdhci@8804000 {
bus-width = <4>;
dma-coherent;

+ /* Forbid SDR104/SDR50 - broken hw! */
+ sdhci-caps-mask = <0x3 0x0>;
+
status = "disabled";

sdhc2_opp_table: opp-table {
--
2.34.1

2022-10-26 20:24:45

by Konrad Dybcio

Subject: Re: [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards

On 26/10/2022 22:03, Krzysztof Kozlowski wrote:
> SDHCI on SM8450 HDK also has problems with SDR104/SDR50:
>
> mmc0: card never left busy state
> mmc0: error -110 whilst initialising SD card
>
> so I think it is safe to assume this issue affects all SM8450 boards.
> Move the quirk disallowing these modes to the SoC DTSI, to spare people
> working on other boards the misery of debugging this issue.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

While I have no way to tell whether this is a common issue, it may as
well be..


Reviewed-by: Konrad Dybcio <[email protected]>


Konrad

> arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts | 2 --
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 +++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> index 718c690af8ad..ae8ba297b0b6 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> @@ -556,8 +556,6 @@ &sdhc_2 {
> pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
> vmmc-supply = <&pm8350c_l9>;
> vqmmc-supply = <&pm8350c_l6>;
> - /* Forbid SDR104/SDR50 - broken hw! */
> - sdhci-caps-mask = <0x3 0x0>;
> no-sdio;
> no-mmc;
> status = "okay";
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 1df5c964c6f7..6800e05a549d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3412,6 +3412,9 @@ sdhc_2: sdhci@8804000 {
> bus-width = <4>;
> dma-coherent;
>
> + /* Forbid SDR104/SDR50 - broken hw! */
> + sdhci-caps-mask = <0x3 0x0>;
> +
> status = "disabled";
>
> sdhc2_opp_table: opp-table {