2020-02-09 16:42:39

by Dmitry Osipenko

[permalink] [raw]
Subject: [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument

Remove unused function argument from handle_continuous_head_request().

Signed-off-by: Dmitry Osipenko <[email protected]>
---
drivers/dma/tegra20-apb-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 7b9d59bbd2c1..3e0373b89195 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -553,7 +553,6 @@ static void tegra_dma_abort_all(struct tegra_dma_channel *tdc)
}

static bool handle_continuous_head_request(struct tegra_dma_channel *tdc,
- struct tegra_dma_sg_req *last_sg_req,
bool to_terminate)
{
struct tegra_dma_sg_req *hsgreq;
@@ -638,7 +637,7 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc,
if (!list_is_last(&sgreq->node, &tdc->pending_sg_req)) {
list_move_tail(&sgreq->node, &tdc->pending_sg_req);
sgreq->configured = false;
- st = handle_continuous_head_request(tdc, sgreq, to_terminate);
+ st = handle_continuous_head_request(tdc, to_terminate);
if (!st)
dma_desc->dma_status = DMA_ERROR;
}
--
2.24.0


2020-02-14 14:17:24

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument


On 09/02/2020 16:33, Dmitry Osipenko wrote:
> Remove unused function argument from handle_continuous_head_request().
>
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
> drivers/dma/tegra20-apb-dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 7b9d59bbd2c1..3e0373b89195 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -553,7 +553,6 @@ static void tegra_dma_abort_all(struct tegra_dma_channel *tdc)
> }
>
> static bool handle_continuous_head_request(struct tegra_dma_channel *tdc,
> - struct tegra_dma_sg_req *last_sg_req,
> bool to_terminate)
> {
> struct tegra_dma_sg_req *hsgreq;
> @@ -638,7 +637,7 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc,
> if (!list_is_last(&sgreq->node, &tdc->pending_sg_req)) {
> list_move_tail(&sgreq->node, &tdc->pending_sg_req);
> sgreq->configured = false;
> - st = handle_continuous_head_request(tdc, sgreq, to_terminate);
> + st = handle_continuous_head_request(tdc, to_terminate);
> if (!st)
> dma_desc->dma_status = DMA_ERROR;
> }
>

Acked-by: Jon Hunter <[email protected]>

Thanks!
Jon

--
nvpublic

2020-02-14 16:55:36

by Dmitry Osipenko

[permalink] [raw]
Subject: Re: [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument

14.02.2020 17:16, Jon Hunter пишет:
...
> Acked-by: Jon Hunter <[email protected]>
>
> Thanks!
> Jon
>

Jon, thank you very much!

In the patchwork I see that you acked all the patches, but my Gmail
missed 2 of 4 emails, maybe the missing emails will arrive a day later :)

2020-02-17 12:34:17

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument


On 14/02/2020 16:54, Dmitry Osipenko wrote:
> 14.02.2020 17:16, Jon Hunter пишет:
> ...
>> Acked-by: Jon Hunter <[email protected]>
>>
>> Thanks!
>> Jon
>>
>
> Jon, thank you very much!
>
> In the patchwork I see that you acked all the patches, but my Gmail
> missed 2 of 4 emails, maybe the missing emails will arrive a day later :)

Yes all should be ACK'ed now. I did receive an email from our mail
server saying that there was an issue and the message was delayed. So
not sure if you ever got it.

Jon

--
nvpublic

2020-02-17 14:57:06

by Dmitry Osipenko

[permalink] [raw]
Subject: Re: [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument

17.02.2020 14:15, Jon Hunter пишет:
>
> On 14/02/2020 16:54, Dmitry Osipenko wrote:
>> 14.02.2020 17:16, Jon Hunter пишет:
>> ...
>>> Acked-by: Jon Hunter <[email protected]>
>>>
>>> Thanks!
>>> Jon
>>>
>>
>> Jon, thank you very much!
>>
>> In the patchwork I see that you acked all the patches, but my Gmail
>> missed 2 of 4 emails, maybe the missing emails will arrive a day later :)
>
> Yes all should be ACK'ed now. I did receive an email from our mail
> server saying that there was an issue and the message was delayed. So
> not sure if you ever got it.

The emails arrived a day later, just like it was predicted :) Thank you
very much for reviewing the patches!