2021-12-17 23:43:54

by James McLaughlin

Subject: [PATCH v2] igc: Fix TX timestamp support for non-MSI-X platforms

Time synchronization was not properly enabled on non-MSI-X platforms.

Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")

Signed-off-by: James McLaughlin <[email protected]>
Reviewed-by: Vinicius Costa Gomes <[email protected]>
---

Having trouble with work email client, understand and agree with comments from Vinicius.
v1->v2 updated commit message, email subject, and reference original commit this is fixing.

drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 8e448288ee26..d28a80a00953 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -5467,6 +5467,9 @@ static irqreturn_t igc_intr_msi(int irq, void *data)
mod_timer(&adapter->watchdog_timer, jiffies + 1);
}

+ if (icr & IGC_ICR_TS)
+ igc_tsync_interrupt(adapter);
+
napi_schedule(&q_vector->napi);

return IRQ_HANDLED;
@@ -5510,6 +5513,9 @@ static irqreturn_t igc_intr(int irq, void *data)
mod_timer(&adapter->watchdog_timer, jiffies + 1);
}

+ if (icr & IGC_ICR_TS)
+ igc_tsync_interrupt(adapter);
+
napi_schedule(&q_vector->napi);

return IRQ_HANDLED;
--
2.25.1

2021-12-27 20:38:47

by Kraus, NechamaX

Subject: Re: [Intel-wired-lan] [PATCH v2] igc: Fix TX timestamp support for non-MSI-X platforms

On 12/18/2021 01:43, James McLaughlin wrote:
> Time synchronization was not properly enabled on non-MSI-X platforms.
>
> Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")
>
> Signed-off-by: James McLaughlin <[email protected]>
> Reviewed-by: Vinicius Costa Gomes <[email protected]>
> ---
>
> Having trouble with work email client, understand and agree with comments from Vinicius.
> v1->v2 updated commit message, email subject, and reference original commit this is fixing.
>
> drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Tested-by: Nechama Kraus <[email protected]>