retries reaches -1, so the iowrite occurrs upon timeout.
Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c
index 62cc789..4b0f0fd 100644
--- a/arch/microblaze/kernel/early_printk.c
+++ b/arch/microblaze/kernel/early_printk.c
@@ -36,7 +36,7 @@ static void early_printk_putc(char c)
unsigned retries = 10000;
/* read status bit - 0x8 offset */
- while (retries-- && (in_be32(base_addr + 8) & (1 << 3)))
+ while (--retries && (in_be32(base_addr + 8) & (1 << 3)))
;
/* Only attempt the iowrite if we didn't timeout */
On Fri, Apr 17, 2009 at 6:49 AM, Roel Kluin <[email protected]> wrote:
> retries reaches -1, so the iowrite occurrs upon timeout.
>
> Signed-off-by: Roel Kluin <[email protected]>
Acked-by: John Williams <[email protected]>
(also applied to PetaLogix SVN)
Thanks,
John
> ---
> diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c
> index 62cc789..4b0f0fd 100644
> --- a/arch/microblaze/kernel/early_printk.c
> +++ b/arch/microblaze/kernel/early_printk.c
> @@ -36,7 +36,7 @@ static void early_printk_putc(char c)
>
> ? ? ? ?unsigned retries = 10000;
> ? ? ? ?/* read status bit - 0x8 offset */
> - ? ? ? while (retries-- && (in_be32(base_addr + 8) & (1 << 3)))
> + ? ? ? while (--retries && (in_be32(base_addr + 8) & (1 << 3)))
> ? ? ? ? ? ? ? ?;
>
> ? ? ? ?/* Only attempt the iowrite if we didn't timeout */
> ___________________________
> microblaze-uclinux mailing list
> [email protected]
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
>
>
--
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: http://www.petalogix.com p: +61-7-30090663 f: +61-7-30090663