2017-03-13 13:54:22

by Simran Singhal

Subject: [PATCH] staging: android: ion: Replace pr_err with dev_err

All devm functions has a device structure as the first argument which is
required by dev_{err,info,dbg} printing functions.
This patch converts pr_err to dev_err as dev_* is preferred after calls
to devm functions.

Done using coccinelle:

@r1 exists@
expression e,e1;
identifier f =~ "^devm_";
identifier g =~ "^pcim_";
identifier h =~ "^dmam_";
@@
e=\(f\|g\|h\)(e1,...);
<+...
(
- pr_info(
+ dev_info(e1,
...);
|
- pr_err(
+ dev_err(e1,
...);
|
- pr_debug(
+ dev_dbg(e1,
...);
)
...+>

Signed-off-by: simran singhal <[email protected]>
---
drivers/staging/android/ion/ion_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c
index 5abf8320..0ab7d11 100644
--- a/drivers/staging/android/ion/ion_test.c
+++ b/drivers/staging/android/ion/ion_test.c
@@ -255,7 +255,7 @@ static int __init ion_test_probe(struct platform_device *pdev)
testdev->misc.parent = &pdev->dev;
ret = misc_register(&testdev->misc);
if (ret) {
- pr_err("failed to register misc device.\n");
+ dev_err(&pdev->dev, "failed to register misc device.\n");
return ret;
}

--
2.7.4

2017-03-13 20:57:21

by Laura Abbott

Subject: Re: [PATCH] staging: android: ion: Replace pr_err with dev_err

On 03/13/2017 06:56 AM, simran singhal wrote:
> All devm functions has a device structure as the first argument which is
> required by dev_{err,info,dbg} printing functions.
> This patch converts pr_err to dev_err as dev_* is preferred after calls
> to devm functions.
>
> Done using coccinelle:
>
> @r1 exists@
> expression e,e1;
> identifier f =~ "^devm_";
> identifier g =~ "^pcim_";
> identifier h =~ "^dmam_";
> @@
> e=\(f\|g\|h\)(e1,...);
> <+...
> (
> - pr_info(
> + dev_info(e1,
> ...);
> |
> - pr_err(
> + dev_err(e1,
> ...);
> |
> - pr_debug(
> + dev_dbg(e1,
> ...);
> )
> ...+>
>
> Signed-off-by: simran singhal <[email protected]>
> ---
> drivers/staging/android/ion/ion_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c
> index 5abf8320..0ab7d11 100644
> --- a/drivers/staging/android/ion/ion_test.c
> +++ b/drivers/staging/android/ion/ion_test.c
> @@ -255,7 +255,7 @@ static int __init ion_test_probe(struct platform_device *pdev)
> testdev->misc.parent = &pdev->dev;
> ret = misc_register(&testdev->misc);
> if (ret) {
> - pr_err("failed to register misc device.\n");
> + dev_err(&pdev->dev, "failed to register misc device.\n");
> return ret;
> }
>
>

Acked-by: Laura Abbott <[email protected]>