2022-11-21 15:57:14

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH resend] thermal: ti-soc-thermal: Drop comma after SoC match table sentinel

It does not make sense to have a comma after a sentinel, as any new
elements must be added before the sentinel.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index 53d409c80753c25e..576c2115df85da72 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -877,7 +877,7 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
*/
static const struct soc_device_attribute soc_no_cpu_notifier[] = {
{ .machine = "OMAP4430" },
- { /* sentinel */ },
+ { /* sentinel */ }
};

/*** Device driver call backs ***/
--
2.25.1



2022-12-01 03:46:58

by Keerthy

[permalink] [raw]
Subject: Re: [PATCH resend] thermal: ti-soc-thermal: Drop comma after SoC match table sentinel



On 11/21/2022 9:17 PM, Geert Uytterhoeven wrote:
> It does not make sense to have a comma after a sentinel, as any new
> elements must be added before the sentinel.

Acked-by: Keerthy <[email protected]>

>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 53d409c80753c25e..576c2115df85da72 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -877,7 +877,7 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
> */
> static const struct soc_device_attribute soc_no_cpu_notifier[] = {
> { .machine = "OMAP4430" },
> - { /* sentinel */ },
> + { /* sentinel */ }
> };
>
> /*** Device driver call backs ***/

2022-12-04 16:44:58

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH resend] thermal: ti-soc-thermal: Drop comma after SoC match table sentinel

On 21/11/2022 16:47, Geert Uytterhoeven wrote:
> It does not make sense to have a comma after a sentinel, as any new
> elements must be added before the sentinel.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog