2023-01-15 22:16:02

by Pierluigi Passaro

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

According section
    8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
of 
    i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
the required setting for this specific pin configuration is "1"

Signed-off-by: Pierluigi Passaro <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h b/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
index 83c8f715cd90..b1f11098d248 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
+++ b/arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h
@@ -602,7 +602,7 @@
#define MX8MM_IOMUXC_UART1_RXD_GPIO5_IO22 0x234 0x49C 0x000 0x5 0x0
#define MX8MM_IOMUXC_UART1_RXD_TPSMP_HDATA24 0x234 0x49C 0x000 0x7 0x0
#define MX8MM_IOMUXC_UART1_TXD_UART1_DCE_TX 0x238 0x4A0 0x000 0x0 0x0
-#define MX8MM_IOMUXC_UART1_TXD_UART1_DTE_RX 0x238 0x4A0 0x4F4 0x0 0x0
+#define MX8MM_IOMUXC_UART1_TXD_UART1_DTE_RX 0x238 0x4A0 0x4F4 0x0 0x1
#define MX8MM_IOMUXC_UART1_TXD_ECSPI3_MOSI 0x238 0x4A0 0x000 0x1 0x0
#define MX8MM_IOMUXC_UART1_TXD_GPIO5_IO23 0x238 0x4A0 0x000 0x5 0x0
#define MX8MM_IOMUXC_UART1_TXD_TPSMP_HDATA25 0x238 0x4A0 0x000 0x7 0x0
--
2.37.2


2023-01-16 19:38:37

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

On Sun, Jan 15, 2023 at 6:35 PM Pierluigi Passaro
<[email protected]> wrote:
>
> According section
> 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> of
> i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> the required setting for this specific pin configuration is "1"
>
> Signed-off-by: Pierluigi Passaro <[email protected]>

Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")

Reviewed-by: Fabio Estevam <[email protected]>

2023-01-21 00:54:40

by Pierluigi Passaro

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

On Mon, Jan 16, 2023 at 8:26 PM Fabio Estevam <[email protected]> wrote:
> On Sun, Jan 15, 2023 at 6:35 PM Pierluigi Passaro
> <[email protected]> wrote:
> >
> > According section
> > 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> > of
> > i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> > the required setting for this specific pin configuration is "1"
> >
> > Signed-off-by: Pierluigi Passaro <[email protected]>
>
> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
>
> Reviewed-by: Fabio Estevam <[email protected]>
>
Thanks for reviewing.
Is there any further action required on my side ?

2023-01-23 15:58:58

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

On 1/21/23 01:37, Pierluigi Passaro wrote:
> On Mon, Jan 16, 2023 at 8:26 PM Fabio Estevam <[email protected]> wrote:
>> On Sun, Jan 15, 2023 at 6:35 PM Pierluigi Passaro
>> <[email protected]> wrote:
>>>
>>> According section
>>> 8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
>>> of
>>> i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
>>> the required setting for this specific pin configuration is "1"
>>>
>>> Signed-off-by: Pierluigi Passaro <[email protected]>
>>
>> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
>>
>> Reviewed-by: Fabio Estevam <[email protected]>
>>
> Thanks for reviewing.
> Is there any further action required on my side ?

Wait for Shawn to review/pick the patch , that's all.

2023-01-26 01:08:29

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: imx8mm: Fix pad control for UART1_DTE_RX

On Sun, Jan 15, 2023 at 10:35:03PM +0100, Pierluigi Passaro wrote:
> According section
> ? ??8.2.5.313 Select Input Register (IOMUXC_UART1_RXD_SELECT_INPUT)
> of?
> ? ??i.MX 8M Mini Applications Processor Reference Manual, Rev. 3, 11/2020
> the required setting for this specific pin configuration is "1"
>
> Signed-off-by: Pierluigi Passaro <[email protected]>

Applied, thanks!