2022-05-14 02:26:28

by Stefan Roese

[permalink] [raw]
Subject: Re: [PATCH -next 2/2] i2c: mt7621: Use devm_platform_get_and_ioremap_resource()

On 13.05.22 12:08, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/i2c/busses/i2c-mt7621.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt7621.c b/drivers/i2c/busses/i2c-mt7621.c
> index f117c3d9ca19..0d849379a236 100644
> --- a/drivers/i2c/busses/i2c-mt7621.c
> +++ b/drivers/i2c/busses/i2c-mt7621.c
> @@ -270,18 +270,15 @@ static void mtk_i2c_init(struct mtk_i2c *i2c)
>
> static int mtk_i2c_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct mtk_i2c *i2c;
> struct i2c_adapter *adap;
> int ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> i2c = devm_kzalloc(&pdev->dev, sizeof(struct mtk_i2c), GFP_KERNEL);
> if (!i2c)
> return -ENOMEM;
>
> - i2c->base = devm_ioremap_resource(&pdev->dev, res);
> + i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(i2c->base))
> return PTR_ERR(i2c->base);
>

Reviewed-by: Stefan Roese <[email protected]>

Thanks,
Stefan