2023-04-24 08:53:07

by Christophe JAILLET

Subject: [PATCH] usb: typec: mux: Remove some unneeded includes

This driver includes many header files that are unneeded.
Remove them and add <linux/device.h> where devm_kzalloc() is defined.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Based on one of my script, this reduces the number of included files
during the build process of this file from 551 to 345.
---
drivers/usb/typec/mux/gpio-sbu-mux.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
index f62516dafe8f..c07856069d43 100644
--- a/drivers/usb/typec/mux/gpio-sbu-mux.c
+++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
@@ -3,14 +3,11 @@
* Copyright (C) 2022 Linaro Ltd.
*/

-#include <linux/bits.h>
-#include <linux/i2c.h>
-#include <linux/kernel.h>
+#include <linux/device.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/gpio/consumer.h>
#include <linux/platform_device.h>
-#include <linux/regmap.h>
#include <linux/usb/typec_dp.h>
#include <linux/usb/typec_mux.h>

--
2.34.1

2023-04-24 13:08:07

by Heikki Krogerus

Subject: Re: [PATCH] usb: typec: mux: Remove some unneeded includes

On Mon, Apr 24, 2023 at 10:39:56AM +0200, Christophe JAILLET wrote:
> This driver includes many header files that are unneeded.
> Remove them and add <linux/device.h> where devm_kzalloc() is defined.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> Based on one of my script, this reduces the number of included files
> during the build process of this file from 551 to 345.
> ---
> drivers/usb/typec/mux/gpio-sbu-mux.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
> index f62516dafe8f..c07856069d43 100644
> --- a/drivers/usb/typec/mux/gpio-sbu-mux.c
> +++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
> @@ -3,14 +3,11 @@
> * Copyright (C) 2022 Linaro Ltd.
> */
>
> -#include <linux/bits.h>
> -#include <linux/i2c.h>
> -#include <linux/kernel.h>
> +#include <linux/device.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/gpio/consumer.h>
> #include <linux/platform_device.h>
> -#include <linux/regmap.h>
> #include <linux/usb/typec_dp.h>
> #include <linux/usb/typec_mux.h>
>
> --
> 2.34.1

--
heikki