2019-11-20 17:33:58

by Amit Kucheria

Subject: [PATCH v2 08/11] thermal: samsung: Appease the kernel-doc deity

Fix up the following warning when compiled with make W=1:

linux.git/drivers/thermal/samsung/exynos_tmu.c:141: warning: bad
line: driver
linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function
parameter or member 'tzd' not described in 'exynos_tmu_data'
linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function
parameter or member 'tmu_set_trip_temp' not described in
'exynos_tmu_data'
linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function
parameter or member 'tmu_set_trip_hyst' not described in
'exynos_tmu_data'

Signed-off-by: Amit Kucheria <[email protected]>
---
drivers/thermal/samsung/exynos_tmu.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index fb2c55123a99..8193b66a3f83 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -138,7 +138,7 @@ enum soc_type {

/**
* struct exynos_tmu_data : A structure to hold the private data of the TMU
- driver
+ * driver
* @id: identifier of the one instance of the TMU controller.
* @base: base address of the single instance of the TMU controller.
* @base_second: base address of the common registers of the TMU controller.
@@ -162,8 +162,11 @@ enum soc_type {
* 0 < reference_voltage <= 31
* @regulator: pointer to the TMU regulator structure.
* @reg_conf: pointer to structure to register with core thermal.
+ * @tzd: pointer to thermal_zone_device structure
* @ntrip: number of supported trip points.
* @enabled: current status of TMU device
+ * @tmu_set_trip_temp: SoC specific method to set trip (rising threshold)
+ * @tmu_set_trip_hyst: SoC specific to set hysteresis (falling threshold)
* @tmu_initialize: SoC specific TMU initialization method
* @tmu_control: SoC specific TMU control method
* @tmu_read: SoC specific TMU temperature read method
--
2.20.1

2019-11-21 05:35:51

by Viresh Kumar

Subject: Re: [PATCH v2 08/11] thermal: samsung: Appease the kernel-doc deity

On 20-11-19, 21:15, Amit Kucheria wrote:
> Fix up the following warning when compiled with make W=1:
>
> linux.git/drivers/thermal/samsung/exynos_tmu.c:141: warning: bad
> line: driver
> linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function
> parameter or member 'tzd' not described in 'exynos_tmu_data'
> linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function
> parameter or member 'tmu_set_trip_temp' not described in
> 'exynos_tmu_data'
> linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function
> parameter or member 'tmu_set_trip_hyst' not described in
> 'exynos_tmu_data'
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Viresh Kumar <[email protected]>

--
viresh