2024-01-04 09:26:27

by Yongzhen Zhang

Subject: [PATCH] ocfs2: Spelling fix

Modify reques to request in the comment

Fixes: b1b1e15ef6b8 ("ocfs2: NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock")
Signed-off-by: Yongzhen Zhang <[email protected]>
---
fs/ocfs2/dlmglue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 64a6ef638495..cb40cafbc062 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -1615,7 +1615,7 @@ static int __ocfs2_cluster_lock(struct ocfs2_super *osb,
unlock:
lockres_clear_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING);

- /* ocfs2_unblock_lock reques on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
+ /* ocfs2_unblock_lock request on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
kick_dc = (lockres->l_flags & OCFS2_LOCK_BLOCKED);

spin_unlock_irqrestore(&lockres->l_lock, flags);
--
2.34.1

2024-01-06 01:56:16

by Joseph Qi

Subject: Re: [PATCH] ocfs2: Spelling fix

On 1/4/24 5:24 PM, Yongzhen Zhang wrote:
> Modify reques to request in the comment
>
> Fixes: b1b1e15ef6b8 ("ocfs2: NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock")

Since it's just a typo, I don't think it deserves a 'Fixes' tag.

> Signed-off-by: Yongzhen Zhang <[email protected]>
> ---
> fs/ocfs2/dlmglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 64a6ef638495..cb40cafbc062 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -1615,7 +1615,7 @@ static int __ocfs2_cluster_lock(struct ocfs2_super *osb,
> unlock:
> lockres_clear_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING);
>
> - /* ocfs2_unblock_lock reques on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
> + /* ocfs2_unblock_lock request on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
> kick_dc = (lockres->l_flags & OCFS2_LOCK_BLOCKED);
>
> spin_unlock_irqrestore(&lockres->l_lock, flags);

2024-01-08 01:56:51

by Yongzhen Zhang

Subject: [PATCH v2] ocfs2: Spelling fix

Modify reques to request in the comment

Signed-off-by: Yongzhen Zhang <[email protected]>
---
fs/ocfs2/dlmglue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 64a6ef638495..cb40cafbc062 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -1615,7 +1615,7 @@ static int __ocfs2_cluster_lock(struct ocfs2_super *osb,
unlock:
lockres_clear_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING);

- /* ocfs2_unblock_lock reques on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
+ /* ocfs2_unblock_lock request on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
kick_dc = (lockres->l_flags & OCFS2_LOCK_BLOCKED);

spin_unlock_irqrestore(&lockres->l_lock, flags);
--
2.34.1

2024-01-08 02:22:13

by Joseph Qi

Subject: Re: [PATCH v2] ocfs2: Spelling fix

On 1/8/24 9:56 AM, Yongzhen Zhang wrote:
> Modify reques to request in the comment
>
> Signed-off-by: Yongzhen Zhang <[email protected]>

Acked-by: Joseph Qi <[email protected]>
> ---
> fs/ocfs2/dlmglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 64a6ef638495..cb40cafbc062 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -1615,7 +1615,7 @@ static int __ocfs2_cluster_lock(struct ocfs2_super *osb,
> unlock:
> lockres_clear_flags(lockres, OCFS2_LOCK_UPCONVERT_FINISHING);
>
> - /* ocfs2_unblock_lock reques on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
> + /* ocfs2_unblock_lock request on seeing OCFS2_LOCK_UPCONVERT_FINISHING */
> kick_dc = (lockres->l_flags & OCFS2_LOCK_BLOCKED);
>
> spin_unlock_irqrestore(&lockres->l_lock, flags);