2018-02-14 13:34:55

by SF Markus Elfring

Subject: [PATCH 0/2] crypto/sahara: Adjustments for sahara_probe()

From: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:30:28 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/crypto/sahara.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.16.1

2018-02-14 13:36:17

by SF Markus Elfring

Subject: [PATCH 1/2] crypto: sahara: Delete an error message for a failed memory allocation in sahara_probe()

From: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:10:03 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/crypto/sahara.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 08e7bdcaa6e3..9f3cdda59139 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -1398,10 +1398,8 @@ static int sahara_probe(struct platform_device *pdev)
int i;

dev = devm_kzalloc(&pdev->dev, sizeof(struct sahara_dev), GFP_KERNEL);
- if (dev == NULL) {
- dev_err(&pdev->dev, "unable to alloc data struct.\n");
+ if (!dev)
return -ENOMEM;
- }

dev->device = &pdev->dev;
platform_set_drvdata(pdev, dev);
--
2.16.1

2018-02-14 13:36:27

by SF Markus Elfring

Subject: [PATCH 2/2] crypto: sahara: Improve a size determination in sahara_probe()

From: Markus Elfring <[email protected]>
Date: Wed, 14 Feb 2018 14:14:05 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/crypto/sahara.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 9f3cdda59139..0f2245e1af2b 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -1397,7 +1397,7 @@ static int sahara_probe(struct platform_device *pdev)
int err;
int i;

- dev = devm_kzalloc(&pdev->dev, sizeof(struct sahara_dev), GFP_KERNEL);
+ dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
if (!dev)
return -ENOMEM;

--
2.16.1

2018-02-22 15:14:34

by Herbert Xu

Subject: Re: [PATCH 0/2] crypto/sahara: Adjustments for sahara_probe()

On Wed, Feb 14, 2018 at 02:32:28PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 14 Feb 2018 14:30:28 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete an error message for a failed memory allocation
> Improve a size determination
>
> drivers/crypto/sahara.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt