2023-12-05 10:12:56

by Yoshinori Sato

[permalink] [raw]
Subject: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

Renesas SH7751 INTC json-schema.

Signed-off-by: Yoshinori Sato <[email protected]>
---
.../renesas,sh7751-intc.yaml | 105 ++++++++++++++++++
1 file changed, 105 insertions(+)
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml

diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml
new file mode 100644
index 000000000000..9d05c10f5c32
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/renesas,sh7751-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas SH7751 Interrupt Controller
+
+maintainers:
+ - Yoshinori Sato <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: renesas,sh7751-intc
+
+ '#interrupt-cells':
+ const: 1
+
+ interrupt-controller: true
+
+ reg:
+ maxItems: 2
+
+ reg-names:
+ items:
+ - const: ICR
+ - const: INTPRI00
+
+ renesas,icr-irlm:
+ type: boolean
+ description: If true ICR.IRLM=1
+
+ renesas,ipr-map:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description: |
+ IRQ to IPR mapping definition.
+ 1st - INTEVT
+ 2nd - Register
+ 3rd - bit index
+
+required:
+ - compatible
+ - '#interrupt-cells'
+ - interrupt-controller
+ - reg
+ - reg-names
+ - renesas,ipr-map
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/sh_intc.h>
+ shintc: interrupt-controller@ffd00000 {
+ compatible = "renesas,sh7751-intc";
+ #interrupt-cells = <1>;
+ interrupt-controller;
+ reg = <0xffd00000 14>, <0xfe080000 128>;
+ reg-names = "ICR", "INTPRI00";
+ renesas,ipr-map = <0x240 IPRD IPR_B12>, /* IRL0 */
+ <0x2a0 IPRD IPR_B8>, /* IRL1 */
+ <0x300 IPRD IPR_B4>, /* IRL2 */
+ <0x360 IPRD IPR_B0>, /* IRL3 */
+ <0x400 IPRA IPR_B12>, /* TMU0 */
+ <0x420 IPRA IPR_B8>, /* TMU1 */
+ <0x440 IPRA IPR_B4>, /* TMU2 TNUI */
+ <0x460 IPRA IPR_B4>, /* TMU2 TICPI */
+ <0x480 IPRA IPR_B0>, /* RTC ATI */
+ <0x4a0 IPRA IPR_B0>, /* RTC PRI */
+ <0x4c0 IPRA IPR_B0>, /* RTC CUI */
+ <0x4e0 IPRB IPR_B4>, /* SCI ERI */
+ <0x500 IPRB IPR_B4>, /* SCI RXI */
+ <0x520 IPRB IPR_B4>, /* SCI TXI */
+ <0x540 IPRB IPR_B4>, /* SCI TEI */
+ <0x560 IPRB IPR_B12>, /* WDT */
+ <0x580 IPRB IPR_B8>, /* REF RCMI */
+ <0x5a0 IPRB IPR_B4>, /* REF ROVI */
+ <0x600 IPRC IPR_B0>, /* H-UDI */
+ <0x620 IPRC IPR_B12>, /* GPIO */
+ <0x640 IPRC IPR_B8>, /* DMAC DMTE0 */
+ <0x660 IPRC IPR_B8>, /* DMAC DMTE1 */
+ <0x680 IPRC IPR_B8>, /* DMAC DMTE2 */
+ <0x6a0 IPRC IPR_B8>, /* DMAC DMTE3 */
+ <0x6c0 IPRC IPR_B8>, /* DMAC DMAE */
+ <0x700 IPRC IPR_B4>, /* SCIF ERI */
+ <0x720 IPRC IPR_B4>, /* SCIF RXI */
+ <0x740 IPRC IPR_B4>, /* SCIF BRI */
+ <0x760 IPRC IPR_B4>, /* SCIF TXI */
+ <0x780 IPRC IPR_B8>, /* DMAC DMTE4 */
+ <0x7a0 IPRC IPR_B8>, /* DMAC DMTE5 */
+ <0x7c0 IPRC IPR_B8>, /* DMAC DMTE6 */
+ <0x7e0 IPRC IPR_B8>, /* DMAC DMTE7 */
+ <0xa00 INTPRI00 IPR_B0>, /* PCIC PCISERR */
+ <0xa20 INTPRI00 IPR_B4>, /* PCIC PCIDMA3 */
+ <0xa40 INTPRI00 IPR_B4>, /* PCIC PCIDMA2 */
+ <0xa60 INTPRI00 IPR_B4>, /* PCIC PCIDMA1 */
+ <0xa80 INTPRI00 IPR_B4>, /* PCIC PCIDMA0 */
+ <0xaa0 INTPRI00 IPR_B4>, /* PCIC PCIPWON */
+ <0xac0 INTPRI00 IPR_B4>, /* PCIC PCIPWDWN */
+ <0xae0 INTPRI00 IPR_B4>, /* PCIC PCIERR */
+ <0xb00 INTPRI00 IPR_B8>, /* TMU3 */
+ <0xb80 INTPRI00 IPR_B12>; /* TMU4 */
+ };
+...
--
2.39.2


2023-12-05 15:02:23

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

Hi Sato-san,

On Tue, Dec 5, 2023 at 10:46 AM Yoshinori Sato
<[email protected]> wrote:
> Renesas SH7751 INTC json-schema.
>
> Signed-off-by: Yoshinori Sato <[email protected]>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml

> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/sh_intc.h>

make dt_binding_check:

fatal error: dt-bindings/interrupt-controller/sh_intc.h: No such file
or directory

sh7751-intc.h

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-12-05 16:04:45

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

On 05/12/2023 10:45, Yoshinori Sato wrote:
> Renesas SH7751 INTC json-schema.
>

This should not be a separate commit from the header bindings. I already
gave such feedback before. Binding headers and bindings documentation
for the same block come together.

> Signed-off-by: Yoshinori Sato <[email protected]>
> ---
> .../renesas,sh7751-intc.yaml | 105 ++++++++++++++++++
> 1 file changed, 105 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml
> new file mode 100644
> index 000000000000..9d05c10f5c32
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/renesas,sh7751-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas SH7751 Interrupt Controller
> +
> +maintainers:
> + - Yoshinori Sato <[email protected]>
> +
> +properties:
> + compatible:
> + items:
> + - const: renesas,sh7751-intc
> +
> + '#interrupt-cells':
> + const: 1
> +
> + interrupt-controller: true
> +
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: ICR
> + - const: INTPRI00

Both lowercase

> +
> + renesas,icr-irlm:
> + type: boolean
> + description: If true ICR.IRLM=1

Unfortunately neither description nor property name tells me anything.
Description basically copies property name, so it's not useful.

> +
> + renesas,ipr-map:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: |
> + IRQ to IPR mapping definition.
> + 1st - INTEVT
> + 2nd - Register
> + 3rd - bit index
> +
> +required:
> + - compatible
> + - '#interrupt-cells'
> + - interrupt-controller
> + - reg
> + - reg-names
> + - renesas,ipr-map
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/sh_intc.h>
> + shintc: interrupt-controller@ffd00000 {
> + compatible = "renesas,sh7751-intc";
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + reg = <0xffd00000 14>, <0xfe080000 128>;
> + reg-names = "ICR", "INTPRI00";

reg should be the second property, reg-names should follow.

Best regards,
Krzysztof