2020-09-27 20:23:09

by Julia Lawall

Subject: [PATCH 10/18] clk: meson: use semicolons rather than commas to separate statements

Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/clk/meson/meson-aoclk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/meson-aoclk.c b/drivers/clk/meson/meson-aoclk.c
index bf8bea675d24..3a6d84cd6601 100644
--- a/drivers/clk/meson/meson-aoclk.c
+++ b/drivers/clk/meson/meson-aoclk.c
@@ -57,7 +57,7 @@ int meson_aoclkc_probe(struct platform_device *pdev)
rstc->data = data;
rstc->regmap = regmap;
rstc->reset.ops = &meson_aoclk_reset_ops;
- rstc->reset.nr_resets = data->num_reset,
+ rstc->reset.nr_resets = data->num_reset;
rstc->reset.of_node = dev->of_node;
ret = devm_reset_controller_register(dev, &rstc->reset);
if (ret) {

2020-09-28 09:51:06

by Jerome Brunet

Subject: Re: [PATCH 10/18] clk: meson: use semicolons rather than commas to separate statements

On Sun 27 Sep 2020 at 21:12, Julia Lawall <[email protected]> wrote:

Hi Stephen,

Do you want to take all the clock related patches directly ?


> Replace commas with semicolons. What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> drivers/clk/meson/meson-aoclk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/meson-aoclk.c b/drivers/clk/meson/meson-aoclk.c
> index bf8bea675d24..3a6d84cd6601 100644
> --- a/drivers/clk/meson/meson-aoclk.c
> +++ b/drivers/clk/meson/meson-aoclk.c
> @@ -57,7 +57,7 @@ int meson_aoclkc_probe(struct platform_device *pdev)
> rstc->data = data;
> rstc->regmap = regmap;
> rstc->reset.ops = &meson_aoclk_reset_ops;
> - rstc->reset.nr_resets = data->num_reset,
> + rstc->reset.nr_resets = data->num_reset;
> rstc->reset.of_node = dev->of_node;
> ret = devm_reset_controller_register(dev, &rstc->reset);
> if (ret) {

2020-10-08 01:57:31

by Stephen Boyd

Subject: Re: [PATCH 10/18] clk: meson: use semicolons rather than commas to separate statements

Quoting Jerome Brunet (2020-09-28 02:47:24)
>
> On Sun 27 Sep 2020 at 21:12, Julia Lawall <[email protected]> wrote:
>
> Hi Stephen,
>
> Do you want to take all the clock related patches directly ?
>
>

Sure that's fine.

2020-10-14 10:16:55

by Stephen Boyd

Subject: Re: [PATCH 10/18] clk: meson: use semicolons rather than commas to separate statements

Quoting Julia Lawall (2020-09-27 12:12:20)
> Replace commas with semicolons. What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---

Applied to clk-next