2019-08-20 12:18:08

by Jerome Brunet

[permalink] [raw]
Subject: [PATCH 0/2] arm64: dts: meson: g12a: add tdm resets

This patchset adds the dedicated reset of the tdm formatters which
have been added on the g12a SoC family. Using these help with the channel
mapping when the formatter uses more than 1 i2s lane.

Kevin, please note that to build, this patchset depends on the new reset
bindings of the audio clock controller. I've prepared a tag for you [0]

[0]: git://github.com/BayLibre/clk-meson.git - clk-meson-dt-v5.4-2

Jerome Brunet (2):
arm64: dts: meson: g12a: audio clock controller provides resets
arm64: dts: meson: g12a: add reset to tdm formatters

arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)

--
2.21.0


2019-08-20 12:18:33

by Jerome Brunet

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: meson: g12a: audio clock controller provides resets

The clock controller dedicated to audio clocks also provides reset lines
on the g12 SoC family

Signed-off-by: Jerome Brunet <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
index 809f741a82ec..8eb92edb7a66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
@@ -1477,6 +1477,7 @@
compatible = "amlogic,g12a-audio-clkc";
reg = <0x0 0x0 0x0 0xb4>;
#clock-cells = <1>;
+ #reset-cells = <1>;

clocks = <&clkc CLKID_AUDIO>,
<&clkc CLKID_MPLL0>,
--
2.21.0

2019-08-21 14:24:50

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: meson: g12a: add tdm resets

On 20/08/2019 14:15, Jerome Brunet wrote:
> This patchset adds the dedicated reset of the tdm formatters which
> have been added on the g12a SoC family. Using these help with the channel
> mapping when the formatter uses more than 1 i2s lane.
>
> Kevin, please note that to build, this patchset depends on the new reset
> bindings of the audio clock controller. I've prepared a tag for you [0]
>
> [0]: git://github.com/BayLibre/clk-meson.git - clk-meson-dt-v5.4-2
>
> Jerome Brunet (2):
> arm64: dts: meson: g12a: audio clock controller provides resets
> arm64: dts: meson: g12a: add reset to tdm formatters
>
> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>

For the serie,

Reviewed-by: Neil Armstrong <[email protected]>

Neil

2019-08-27 23:44:04

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: meson: g12a: add tdm resets

Jerome Brunet <[email protected]> writes:

> This patchset adds the dedicated reset of the tdm formatters which
> have been added on the g12a SoC family. Using these help with the channel
> mapping when the formatter uses more than 1 i2s lane.

Because I forgot^W waited on this, we did the meson-g12a-common split,
so this no longer applies cleanly. Could you rebase this on current v5.4/dt64
and I'll queue it for v5.4/dt64.

> Kevin, please note that to build, this patchset depends on the new reset
> bindings of the audio clock controller. I've prepared a tag for you [0]
>
> [0]: git://github.com/BayLibre/clk-meson.git - clk-meson-dt-v5.4-2

Thanks for the tag. This is now included in v5.4/dt64.

Kevin

2019-08-28 08:05:43

by Jerome Brunet

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: meson: g12a: add tdm resets

On Tue 27 Aug 2019 at 16:42, Kevin Hilman <[email protected]> wrote:

> Jerome Brunet <[email protected]> writes:
>
>> This patchset adds the dedicated reset of the tdm formatters which
>> have been added on the g12a SoC family. Using these help with the channel
>> mapping when the formatter uses more than 1 i2s lane.
>
> Because I forgot^W waited on this, we did the meson-g12a-common split,
> so this no longer applies cleanly. Could you rebase this on current v5.4/dt64
> and I'll queue it for v5.4/dt64.

Acutally it was already not applying when I sent this v1 ...
.. which is why I sent a v2 [0] ;)

[0]: https://lkml.kernel.org/r/[email protected]

>
>> Kevin, please note that to build, this patchset depends on the new reset
>> bindings of the audio clock controller. I've prepared a tag for you [0]
>>
>> [0]: git://github.com/BayLibre/clk-meson.git - clk-meson-dt-v5.4-2
>
> Thanks for the tag. This is now included in v5.4/dt64.
>
> Kevin

2019-08-28 15:06:56

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: meson: g12a: add tdm resets

Jerome Brunet <[email protected]> writes:

> On Tue 27 Aug 2019 at 16:42, Kevin Hilman <[email protected]> wrote:
>
>> Jerome Brunet <[email protected]> writes:
>>
>>> This patchset adds the dedicated reset of the tdm formatters which
>>> have been added on the g12a SoC family. Using these help with the channel
>>> mapping when the formatter uses more than 1 i2s lane.
>>
>> Because I forgot^W waited on this, we did the meson-g12a-common split,
>> so this no longer applies cleanly. Could you rebase this on current v5.4/dt64
>> and I'll queue it for v5.4/dt64.
>
> Acutally it was already not applying when I sent this v1 ...
> .. which is why I sent a v2 [0] ;)
>
> [0]: https://lkml.kernel.org/r/[email protected]

Oops, I saw there was a v2, but I missed that in my `git pw` because v2
of the series had an "ASoC:" prefix in the cover letter, not an "arm64:
dts" one, so I skimmed past it.

Kevin

2019-08-28 15:13:32

by Jerome Brunet

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: meson: g12a: add tdm resets

On Wed 28 Aug 2019 at 08:05, Kevin Hilman <[email protected]> wrote:

> Jerome Brunet <[email protected]> writes:
>
>> On Tue 27 Aug 2019 at 16:42, Kevin Hilman <[email protected]> wrote:
>>
>>> Jerome Brunet <[email protected]> writes:
>>>
>>>> This patchset adds the dedicated reset of the tdm formatters which
>>>> have been added on the g12a SoC family. Using these help with the channel
>>>> mapping when the formatter uses more than 1 i2s lane.
>>>
>>> Because I forgot^W waited on this, we did the meson-g12a-common split,
>>> so this no longer applies cleanly. Could you rebase this on current v5.4/dt64
>>> and I'll queue it for v5.4/dt64.
>>
>> Acutally it was already not applying when I sent this v1 ...
>> .. which is why I sent a v2 [0] ;)
>>
>> [0]: https://lkml.kernel.org/r/[email protected]
>
> Oops, I saw there was a v2, but I missed that in my `git pw` because v2
> of the series had an "ASoC:" prefix in the cover letter, not an "arm64:
> dts" one, so I skimmed past it.

Oh ! indeed and this prefix makes no sense. Sorry about that

>
> Kevin