2000-10-28 07:02:21

by Jens Axboe

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

On Sat, Oct 28 2000, Hisaaki Shibata wrote:
> I did patch 2.2.17 tree with dvd-ram-2217p17.diff.bz2.
>
> At that time, following patch is rejected.
> I think these lines should be removed from patchs.
>
> @@ -1329,7 +1369,7 @@
> static
> void cdrom_sleep (int time)
> {
> - current->state = TASK_INTERRUPTIBLE;
> + __set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(time);
> }
>
> After removing these, I could make bzImage.

Weird, should not reject. Oh well.

> But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.

What do you mean? What happened? strace of mke2fs of mkudf would
be nice to have.

--
* Jens Axboe <[email protected]>
* SuSE Labs


2000-10-28 14:24:53

by Hisaaki Shibata

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

Thanks, Axboe

> > But I could not mkudf nor mkext2fs to my ATAPI 9.4GB new DVD-RAM drive.
>
> What do you mean? What happened? strace of mke2fs of mkudf would
> be nice to have.

My system said it is not permited because it is read only.

execve("/sbin/mke2fs", ["/sbin/mke2fs", "/dev/hdc"], [/* 19 vars */]) = 0
brk(0) = 0x804dd80
old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40013000
open("/etc/ld.so.preload", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=19214, ...}) = 0
old_mmap(NULL, 19214, PROT_READ, MAP_PRIVATE, 3, 0) = 0x40014000
close(3) = 0
open("/lib/libext2fs.so.2", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0755, st_size=83284, ...}) = 0
read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0\2146\0"..., 4096) = 4096
old_mmap(NULL, 71696, PROT_READ|PROT_EXEC, MAP_PRIVATE, 3, 0) = 0x40019000
mprotect(0x4002a000, 2064, PROT_NONE) = 0
old_mmap(0x4002a000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED, 3, 0x10000) = 0x4002a000
close(3) = 0
open("/lib/libcom_err.so.2", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0755, st_size=8057, ...}) = 0
read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0\230\t\0"..., 4096) = 4096


And /proc/ide/hdc/media says "cdrom". Is it OK?


Best Regards,

--
WWWWW [email protected]
|O-O| Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233 IRC: #luky
~ http://his.luky.org/ last update:2000.3.12

2000-10-29 03:08:30

by Jens Axboe

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

On Sun, Oct 29 2000, Hisaaki Shibata wrote:
> > Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?
>
> Yes.
> I think it seems good.
>
> # more info
> CD-ROM information, Id: cdrom.c 3.12 2000/10/22
>
> Can write DVD-RAM: 1

So far, so good.

> Should I set any flags to permit write a DVD-RAM media ?

No, as I said it should detect it automatically. But d'oh, I
just realised that it is set too soon... Sorry, try with this
patch.

--
* Jens Axboe <[email protected]>
* SuSE Labs


Attachments:
(No filename) (501.00 B)
dvdram-ro_fix.diff (732.00 B)
Download all attachments

2000-10-29 04:39:23

by Hisaaki Shibata

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

Thanks again.

> > > Ok, does /proc/sys/dev/cdrom/info list DVD-RAM as a capability?

> > CD-ROM information, Id: cdrom.c 3.12 2000/10/22
> >
> > Can write DVD-RAM: 1
>
> So far, so good.

:-)

> > Should I set any flags to permit write a DVD-RAM media ?
>
> No, as I said it should detect it automatically. But d'oh, I
> just realised that it is set too soon... Sorry, try with this
> patch.

Thank you for your quick response.

I tried the patch.
But kernel said Oops both fdisk /dev/hdc and
dd if=/dev/zero of=/dev/hdc bs=2048 count=1 .

strace dd if=/dev/zero of=/dev/hdc bs=2048 count=1 shows
-----------------------------------------------------------------------------
[root@celto shibata]# strace dd if=/dev/zero of=/dev/hdc bs=2048 count=1
execve("/bin/dd", ["dd", "if=/dev/zero", "of=/dev/hdc", "bs=2048", "count=1"], [/* 19 vars */]) = 0
brk(0) = 0x80504a8
old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40013000
open("/etc/ld.so.preload", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=19214, ...}) = 0
old_mmap(NULL, 19214, PROT_READ, MAP_PRIVATE, 3, 0) = 0x40014000
close(3) = 0
open("/lib/libc.so.6", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0755, st_size=5224080, ...}) = 0
read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0(\215\1"..., 4096) = 4096
old_mmap(NULL, 941692, PROT_READ|PROT_EXEC, MAP_PRIVATE, 3, 0) = 0x40019000
mprotect(0x400f7000, 32380, PROT_NONE) = 0
old_mmap(0x400f7000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED, 3, 0xdd000) = 0x400f7000
old_mmap(0x400fc000, 11900, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x400fc000
close(3) = 0
munmap(0x40014000, 19214) = 0
personality(PER_LINUX) = 0
getpid() = 709
brk(0) = 0x80504a8
brk(0x80504e0) = 0x80504e0
brk(0x8051000) = 0x8051000
close(0) = 0
open("/dev/zero", O_RDONLY|O_LARGEFILE) = 0
close(1) = 0
open("/dev/hdc", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = -1 ENOSYS (Function not implemented)
open("/dev/hdc", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = -1 ENOSYS (Function not implemented)
open("/dev/hdc", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 1
rt_sigaction(SIGINT, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGINT, {0x804adec, [], 0x4000000}, NULL, 8) = 0
rt_sigaction(SIGQUIT, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGQUIT, {0x804adec, [], 0x4000000}, NULL, 8) = 0
rt_sigaction(SIGPIPE, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGPIPE, {0x804adec, [], 0x4000000}, NULL, 8) = 0
rt_sigaction(SIGUSR1, NULL, {SIG_DFL}, 8) = 0
rt_sigaction(SIGUSR1, {0x804aeac, [], 0x4000000}, NULL, 8) = 0
brk(0x8054000) = 0x8054000
read(0, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 2048) = 2048
write(1, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 2048) = 2048
write(2, "1+0 records in\n", 151+0 records in
) = 15
write(2, "1+0 records out\n", 161+0 records out
) = 16
close(0) = 0
close(1

-----------------------------------------------------------------------------
After showing above strace message in a few seconds, kernel panic happened.

I can not see some head line of Oops messages. Sorry.

Please let me test more patches. I will keep up with you.

Best Regards,

--
WWWWW [email protected]
|O-O| Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233 IRC: #luky
~ http://his.luky.org/ last update:2000.3.12

2000-10-30 21:54:52

by Jens Axboe

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

On Tue, Oct 31 2000, Hisaaki Shibata wrote:
> By using serial console, I get messages for you ;-)

Thanks, now you're just one step short of being really
helpful :-). Pass it through ksymoops please, so the
addresses will map to function names + offsets.

> In case of doing "dd if=/dev/zero of=/dev/hdc bs=2048 count=1".
> ----------------------------------------------------------------------------
> hdc: ATAPI DVD-ROM DVD-RAM drive, 512kB Cache, UDMA(33)
> hdc: timeout waiting for DMA
> ide_dmaproc: chipset supported ide_dma_timeout func only: 14

Try it without DMA as well, please. I think I see a DMA bug in there right
now, I'll recheck and send you a new patch.

--
* Jens Axboe <[email protected]>
* SuSE Labs

2000-10-31 16:05:47

by Hisaaki Shibata

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

Hi,

> > By using serial console, I get messages for you ;-)
>
> Thanks, now you're just one step short of being really
> helpful :-). Pass it through ksymoops please, so the
> addresses will map to function names + offsets.

I atacched files. Is it OK?

> > hdc: timeout waiting for DMA
> > ide_dmaproc: chipset supported ide_dma_timeout func only: 14
>
> Try it without DMA as well, please. I think I see a DMA bug in there right
> now, I'll recheck and send you a new patch.

I see. I will try it and will report it.

Best Regards,

--
WWWWW [email protected]
|O-O| Hisaaki Shibata
0(mmm)0 P-mail: 070-5419-3233 IRC: #luky
~ http://his.luky.org/ last update:2000.3.12


Attachments:
trace2.txt (4.47 kB)
trace1.txt (3.85 kB)
Download all attachments

2000-11-12 08:36:20

by Jens Axboe

[permalink] [raw]
Subject: Re: patch: atapi dvd-ram support

On Sat, Nov 11 2000, Hisaaki Shibata wrote:
> > Or you could try the 2.4 version, as I said originally the 2.2 patch
> > hasn't been tested at all. It would be nice to know if that works
> > for you, as I may have screwed up the backport a bit.
>
> I tested on 2.4-test10 + dvd-ram-240t10p5.diff.bz2 + dvdram-ro_fix.diff env.
> It occured oops too :-(.

Interesting, then it isn't the backport that is buggy.

> And I forgot to say that my DVD-RAM drive is a new 9.4GB DVD-RAM model drive.

I'd like to know specifically what make/model drive you have? The
oops you sent earlier seems to indicate an empty ide dma request setup.
If you disable DMA on the drive, does it then work? I'd send you a
patch right now, but I have to unpack my trees first.

--
* Jens Axboe <[email protected]>
* SuSE Labs