2000-11-01 11:05:30

by Martin Mares

[permalink] [raw]
Subject: Re: [PATCH] make my life easier ...

Hello!

> Aside from all of the other comments that've been made, because the user might
> have tweeked them at boot. ie turn on UDMA. If we just re-initalized on
> wakeup, you loose this.

I've of course meant reinitialize with the user-supplied settings, just as we
do during normal initialization/configuration of the driver.

Have a nice fortnight
--
Martin `MJ' Mares <[email protected]> <[email protected]> http://atrey.karlin.mff.cuni.cz/~mj/
"The computer is mightier than the pen, the sword, and usually, the programmer."


2000-11-01 15:38:11

by Andre Hedrick

[permalink] [raw]
Subject: Re: [PATCH] make my life easier ...

On Wed, 1 Nov 2000, Martin Mares wrote:

> Hello!
>
> > Aside from all of the other comments that've been made, because the user might
> > have tweeked them at boot. ie turn on UDMA. If we just re-initalized on
> > wakeup, you loose this.
>
> I've of course meant reinitialize with the user-supplied settings, just as we
> do during normal initialization/configuration of the driver.

No, we put it back in the mode it was in before APM wacked.
Yes, if we call the settings before APM wacks it 'user settings'.

Cheers,

Andre Hedrick
CTO Timpanogas Research Group
EVP Linux Development, TRG
Linux ATA Development