2000-11-10 11:30:00

by Andrey Panin

[permalink] [raw]
Subject: [PATCH] NIC drivers check_region() removal continues


Hi all,

new net drivers patchset (against 2.4.0-test11-pre1) attached.

Modifications: check_region() removal, passing dev->name to
request_region() & request_irq() etc.

Drivers affected: 3c501.c, 3c503.c, 3c505.c, 82596.c, eth16i.c, hp.c,
hp-plus.c, ibmlana.c, ne2.c, seeq8005.c, smc-mca.c, smc-ultra.c,
smc-ultra32.c

Best regard,
Andrey

--
Andrey Panin | Embedded systems software engineer
[email protected] | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.asc


Attachments:
patch-3c501 (720.00 B)
patch-3c503 (2.80 kB)
patch-3c505 (1.12 kB)
patch-82596 (1.32 kB)
patch-eth16i (2.84 kB)
patch-hp (1.21 kB)
patch-hp-plus (945.00 B)
patch-ibmlana (2.66 kB)
patch-ne2 (2.46 kB)
patch-seeq8005 (3.24 kB)
patch-smc-mca (1.39 kB)
patch-smc-ultra (2.99 kB)
patch-smc-ultra32 (4.19 kB)
(No filename) (232.00 B)
Download all attachments

2000-11-10 14:31:35

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] NIC drivers check_region() removal continues

Andrey Panin wrote:
>
> Hi all,
>
> new net drivers patchset (against 2.4.0-test11-pre1) attached.
>
> Modifications: check_region() removal, passing dev->name to
> request_region() & request_irq() etc.
>
> Drivers affected: 3c501.c, 3c503.c, 3c505.c, 82596.c, eth16i.c, hp.c,
> hp-plus.c, ibmlana.c, ne2.c, seeq8005.c, smc-mca.c, smc-ultra.c,
> smc-ultra32.c

Most patches applied, thanks. Comments:

3c505.c: You must abort if dma_mem_alloc return value is null, not just
print a message.
82596.c: Not applied. My moving the "if checksum & 0x100" line, you
make the code comments incorrect.
eth16i.c: Your diff was not created in the main linux directory...
seeq8005.c: Applied, but you forgot dev->name in request_region

--
Jeff Garzik |
Building 1024 | Would you like a Twinkie?
MandrakeSoft |