2000-12-11 23:51:38

by Frédéric L. W. Meunier

[permalink] [raw]
Subject: [PATCH] ide-pci.c: typo

dmesg: VP_IDE: not 100% native mode: will probe irqs later
syslog: Dec 11 14:28:48 pervalidus kernel: VP_IDE: not 100%% native mode: will probe irqs later


--
0@pervalidus.{net,{dyndns.}org} TelFax: 55-21-717-2399 (Niter?i-RJ BR)


Attachments:
(No filename) (232.00 B)
ide-pci.c.diff (514.00 B)
Download all attachments

2000-12-12 00:39:02

by Alan

[permalink] [raw]
Subject: Re: [PATCH] ide-pci.c: typo

> if ((dev->class & ~(0xfa)) != ((PCI_CLASS_STORAGE_IDE << 8) | 5)) {
> - printk("%s: not 100%% native mode: will probe irqs later\n", d->name);
> + printk("%s: not 100% native mode: will probe irqs later\n", d->name);
> pciirq = ide_special_settings(dev, d->name);

I disagree with the patch. The bug is in printk


2000-12-12 01:22:28

by Frédéric L. W. Meunier

[permalink] [raw]
Subject: Re: [PATCH] ide-pci.c: typo

Alan Cox wrote:

> I disagree with the patch. The bug is in printk

No problem. So, it's a bug report instead. I have no clues,
and just thought it'd be a fix :)

Not sure if 2.2.17 reported the double %% from syslog. I
usually look at my dmesg.

--
0@pervalidus.{net,{dyndns.}org} TelFax: 55-21-717-2399 (Niter?i-RJ BR)

2000-12-12 01:37:31

by Bruce Korb

[permalink] [raw]
Subject: Re: [PATCH] ide-pci.c: typo

Fr?d?ric L . W . Meunier wrote:
>
> Alan Cox wrote:
...

There are several typos, but it is not clear if they are all
from ide-pci.c, or in the other files (pci.ids and pci_ids.h).

2000-12-12 16:48:05

by Matthew Kirkwood

[permalink] [raw]
Subject: Re: [PATCH] ide-pci.c: typo

On Mon, 11 Dec 2000, Fr?d?ric L . W . Meunier wrote:

> > I disagree with the patch. The bug is in printk
>
> No problem. So, it's a bug report instead. I have no clues, and just
> thought it'd be a fix :)
>
> Not sure if 2.2.17 reported the double %% from syslog. I usually look
> at my dmesg.

If it matters, I have vague recollections that the double %%
was added to prevent klogd from segfaulting. Since everyone
has fixed their klogd's because that bug was actually (probably)
an exploitable security hole, all should be well, right?

Matthew.