2001-02-22 09:12:36

by Andrey Panin

[permalink] [raw]

Subject: [PATCH] drivers/net/sunhme.c, unbalanced and unchecked ioremap()

---

Hi all,

I found that sunhme.c doesn't check ioremap() return value and doesn't
call iounmap() on module unload. Attached patch (for 2.4.1-ac20) should fix it,
compiles clearly, but untested (I have no such hardware).

Best regards.

--
Andrey Panin | Embedded systems software engineer
[email protected] | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.asc

---

Attachments:

patch-ioremap-sunhme (776.00 B)
(No filename) (232.00 B)
Download all attachments

2001-02-22 10:35:39

by David Miller

[permalink] [raw]

Subject: Re: [PATCH] drivers/net/sunhme.c, unbalanced and unchecked ioremap()

---

Andrey Panin writes:
> I found that sunhme.c doesn't check ioremap() return value and doesn't
> call iounmap() on module unload. Attached patch (for 2.4.1-ac20) should fix it,
> compiles clearly, but untested (I have no such hardware).

Thanks I've applied this patch.

Later,
David S. Miller
[email protected]