2001-03-02 16:53:51

by Alexander Zarochentsev

[permalink] [raw]
Subject: [PATCH] adds missed lock_kernel/unlock_kernel to reiserfs_dir_fsync().

Hi !

Bug found in reiserfs in linux-2.4.2: reiserfs_dir_fsync has no
lock_kernel/unlock_kernel calls which are required by reiserfs journal
interface functions. It causes reserfs_panic in any attempt to fsync a
directory (on SMP machines).

Bug report was related to qmail which likes to
fsync a directory.

This trivial fix cures the problem:

--- linux.old/fs/reiserfs/dir.c Fri Mar 2 14:48:12 2001
+++ linux/fs/reiserfs/dir.c Fri Mar 2 14:49:31 2001
@@ -51,12 +51,16 @@
int windex ;
struct reiserfs_transaction_handle th ;

+ lock_kernel();
+
journal_begin(&th, dentry->d_inode->i_sb, 1) ;
windex = push_journal_writer("dir_fsync") ;
reiserfs_prepare_for_journal(th.t_super, SB_BUFFER_WITH_SB(th.t_super), 1) ;
journal_mark_dirty(&th, dentry->d_inode->i_sb, SB_BUFFER_WITH_SB (dentry->d_inode->i_sb)) ;
pop_journal_writer(windex) ;
journal_end_sync(&th, dentry->d_inode->i_sb, 1) ;
+
+ unlock_kernel();

return ret ;
}


Regards,
Alex.