hi,
I noticed that the option CONFIG_PARIDE_PARPORT will always be "y",
even if CONFIG_PARIDE_PARPORT="n". I checked with kernels 2.2.18
and 2.2.19.
the file responsible is "drivers/block/Config.in", around line 126.
it reads:
# PARIDE doesn't need PARPORT, but if PARPORT is configured as a module,
# PARIDE must also be a module. The bogus CONFIG_PARIDE_PARPORT option
# controls the choices given to the user ...
if [ "$CONFIG_PARPORT" = "y" -o "$CONFIG_PARPORT" = "n" ] ; then
define_bool CONFIG_PARIDE_PARPORT y
else
define_bool CONFIG_PARIDE_PARPORT m
fi
so, as you can see, CONFIG_PARIDE_PARPORT will be set to "yes" even
if CONFIG_PARPORT="no".
why not simply write:
define_bool CONFIG_PARIDE_PARPORT $CONFIG_PARPORT
instead?
regards,
herbert rosmanith
[email protected]
On Fri, Mar 30, 2001 at 10:17:08PM +0200, Herbert Rosmanith wrote:
> why not simply write:
>
> define_bool CONFIG_PARIDE_PARPORT $CONFIG_PARPORT
>
> instead?
Because it isn't that simple. PARIDE works with parport, or without
parport, but if parport is a module then PARIDE must be configured as
modules too.
I'm planning on changing that in the next development cycle so that
PARIDE just depends on parport and that's it.
Tim.
*/
On Fri, Mar 30, 2001 at 10:17:08PM +0200, Herbert Rosmanith wrote:
>
> hi,
>
> I noticed that the option CONFIG_PARIDE_PARPORT will always be "y",
> even if CONFIG_PARIDE_PARPORT="n". I checked with kernels 2.2.18
> and 2.2.19.
>
> the file responsible is "drivers/block/Config.in", around line 126.
> it reads:
>
> # PARIDE doesn't need PARPORT, but if PARPORT is configured as a module,
> # PARIDE must also be a module. The bogus CONFIG_PARIDE_PARPORT option
> # controls the choices given to the user ...
>
> if [ "$CONFIG_PARPORT" = "y" -o "$CONFIG_PARPORT" = "n" ] ; then
> define_bool CONFIG_PARIDE_PARPORT y
> else
> define_bool CONFIG_PARIDE_PARPORT m
> fi
>
> so, as you can see, CONFIG_PARIDE_PARPORT will be set to "yes" even
> if CONFIG_PARPORT="no".
>
> why not simply write:
>
> define_bool CONFIG_PARIDE_PARPORT $CONFIG_PARPORT
>
> instead?
In fact, if we want to get what is said in the comment, we should write:
if [ "$CONFIG_PARPORT" = "m" -a "$CONFIG_PARIDE_PARPORT" = "y" ] ; then
define_bool CONFIG_PARIDE_PARPORT m
fi
regards,
Balazs Pozsar.
On Sat, Mar 31, 2001 at 04:00:27PM +0200, Pozsar Balazs wrote:
> On Fri, Mar 30, 2001 at 10:17:08PM +0200, Herbert Rosmanith wrote:
> In fact, if we want to get what is said in the comment, we should write:
>
> if [ "$CONFIG_PARPORT" = "m" -a "$CONFIG_PARIDE_PARPORT" = "y" ] ; then
> define_bool CONFIG_PARIDE_PARPORT m
> fi
But the condition is never satisfied.
Tim.
*/