2001-04-24 08:19:51

by Alex Riesen

[permalink] [raw]
Subject: broken_apm_power in dmi_scan.c - no return value

Hi, dear lkml,

The mentioned function doesn't return any value, but the calling
code (dmi_check_black_list) depend on it:

static __init int broken_apm_power(struct dmi_blacklist *d)
{
apm_info.get_power_status_broken = 1;
printk(KERN_WARNING "BIOS strings suggest APM bugs, disabling power status reporting.\n");
return 0; /* continue scan */
}

In dmi_check_blacklist:

if(d->callback(d)) /* callback is a pointer on a function, like broken_apm_power */
return;

Alex Riesen