2001-07-15 23:47:52

by Thomas Langås

Subject: [PATCH] Make SCSI-system aware of type 12-devices

This small patch doesn't display "Unkown" when a type 12 device is found,
when scanning for scsi-devices on a scsi-chain. I also included the
declaration of TYPE_PRINTER which wasn't there. All theese types are
described in ftp://ftp.t10.org/t10/drafts/spc/spc-r11a.pdf page 51,
table 21.

--
-Thomas

diff -urN -X dontdiff linux-2.4.7-pre6/drivers/scsi/scsi.c linux-2.4.7-pre6_patched/drivers/scsi/scsi.c
--- linux-2.4.7-pre6/drivers/scsi/scsi.c Tue Jun 12 20:06:54 2001
+++ linux-2.4.7-pre6_patched/drivers/scsi/scsi.c Mon Jul 16 00:37:59 2001
@@ -130,7 +130,7 @@
"Communications ",
"Unknown ",
"Unknown ",
- "Unknown ",
+ "Storage Array ",
"Enclosure ",
};

diff -urN -X dontdiff linux-2.4.7-pre6/include/scsi/scsi.h linux-2.4.7-pre6_patched/include/scsi/scsi.h
--- linux-2.4.7-pre6/include/scsi/scsi.h Fri Apr 27 22:59:19 2001
+++ linux-2.4.7-pre6_patched/include/scsi/scsi.h Mon Jul 16 00:34:45 2001
@@ -130,6 +130,7 @@

#define TYPE_DISK 0x00
#define TYPE_TAPE 0x01
+#define TYPE_PRINTER 0x02
#define TYPE_PROCESSOR 0x03 /* HP scanners use this */
#define TYPE_WORM 0x04 /* Treated as ROM by our system */
#define TYPE_ROM 0x05
@@ -138,6 +139,7 @@
* - treated as TYPE_DISK */
#define TYPE_MEDIUM_CHANGER 0x08
#define TYPE_COMM 0x09 /* Communications device */
+#define TYPE_SACD 0x0c /* Storage Array Controller Device, e.g. RAID */
#define TYPE_ENCLOSURE 0x0d /* Enclosure Services Device */
#define TYPE_NO_LUN 0x7f

2001-07-16 00:15:29

by Pete Zaitcev

Subject: Re: [PATCH] Make SCSI-system aware of type 12-devices

> This small patch doesn't display "Unkown" when a type 12 device is found,
> when scanning for scsi-devices on a scsi-chain. I also included the
> declaration of TYPE_PRINTER which wasn't there. All theese types are
> described in ftp://ftp.t10.org/t10/drafts/spc/spc-r11a.pdf page 51,
> table 21.

Yeah, however nobody tried to implement SCC command class before.
It is much easier for a controller vendor to provide REPORT_LUNS
(which is enough to find volumes), and have some out-of-band
management interface - front panel, telnet, or a web form.
Out of curiousity, what is your hardware?

The patch looks ok.

-- Pete

2001-07-16 00:37:30

by Thomas Langås

Subject: Re: [PATCH] Make SCSI-system aware of type 12-devices

Pete Zaitcev:
> Yeah, however nobody tried to implement SCC command class before.
> It is much easier for a controller vendor to provide REPORT_LUNS
> (which is enough to find volumes), and have some out-of-band
> management interface - front panel, telnet, or a web form.

This controller has a consolle which you can hook up to, to do management.

> Out of curiousity, what is your hardware?

Compaq StorageWorks (announced vendor is DEC, tho) HSG80.

--
-Thomas