2001-07-18 19:23:54

by Arjan van de Ven

Subject: acpi patch in 2.4.6

Hi,

How is the following chunk taken from patch-2.4.6 ever going to work ?

diff -u --recursive --new-file v2.4.5/linux/drivers/acpi/os.c
linux/drivers/acpi/os.c
--- v2.4.5/linux/drivers/acpi/os.c Mon Jan 22 13:23:43 2001
+++ linux/drivers/acpi/os.c Sun Jun 24 20:53:07 2001
@@ -248,27 +293,27 @@
void
acpi_os_mem_out8 (ACPI_PHYSICAL_ADDRESS phys_addr, UINT8 value)
{
- *(u8*) (u32) phys_addr = value;
+ *(u8*) phys_to_virt(phys_addr) = value;
}

2001-07-18 21:26:45

by Linus Torvalds

Subject: Re: acpi patch in 2.4.6

On Wed, 18 Jul 2001, Arjan van de Ven wrote:
>
> How is the following chunk taken from patch-2.4.6 ever going to work ?

Because ACPI physical addresses are _physical_ memory addresses, and we
have a 1:1 mapping for most of them (notably the BIOS extended areas).

Linus