Available in the usual places..
Linus
---
pre2:
- me/Al Viro: fix bdget() oops with block device modules that don't
clean up after they exit
- Alan Cox: continued merging (drivers, license tags)
- David Miller: sparc update, network fixes
- Christoph Hellwig: work around broken drivers that add a gendisk more
than once
- Jakub Jelinek: handle more ELF loading special cases
- Trond Myklebust: NFS client and lockd reclaimer cleanups/fixes
- Greg KH: USB updates
- Mikael Pettersson: sparate out local APIC / IO-APIC config options
pre1:
- Chris Mason: fix ppp race conditions
- me: buffers-in-pagecache coherency, buffer.c cleanups
- Al Viro: block device cleanups/fixes
- Anton Altaparmakov: NTFS 1.1.20 update
- Andrea Arcangeli: VM tweaks
Linus Torvalds wrote:
>
> Available in the usual places..
>
There is a leftover wakeup_bdflush(0) in sysrq.c, I guess
it should be wakeup_bdflush(). Well at least it builds
after the above fix :)
--alessandro
"this is no time to get cute, it's a mad dog's promenade
so walk tall, or baby don't walk at all"
(Bruce Springsteen, 'New York City Serenade')
I get:
gcc -D__KERNEL__ -I/home/src/linux-2.4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -DEXPORT_SYMTAB -c sysrq.c
sysrq.c: In function `sysrq_handle_mountro':
sysrq.c:234: too many arguments to function `wakeup_bdflush'
make[3]: *** [sysrq.o] Error 1
make[3]: Leaving directory `/home/src/linux-2.4/drivers/char'
Seems this patch to drivers/char/sysrq.c should not be in:
static void sysrq_handle_mountro(int key, struct pt_regs *pt_regs,
struct kbd_struct *kbd, struct tty_struct *tty) {
emergency_sync_scheduled = EMERG_REMOUNT;
- wakeup_bdflush();
+ wakeup_bdflush(0);
}
--
Henrik Storner <[email protected]>
On Tue, Oct 02, 2001 at 12:18:16AM +0200, [email protected] wrote:
> Seems this patch to drivers/char/sysrq.c should not be in:
While we're fixing typos in sysrq.c:
--- linux.vanilla/drivers/char/sysrq.c Tue Oct 2 12:46:39 2001
+++ linux/drivers/char/sysrq.c Tue Oct 2 12:47:15 2001
@@ -236,7 +236,7 @@
static struct sysrq_key_op sysrq_mountro_op = {
handler: sysrq_handle_mountro,
help_msg: "Unmount",
- action_msg: "Emergency Remount R/0\n",
+ action_msg: "Emergency Remount R/O\n",
};
/* END SYNC SYSRQ HANDLERS BLOCK */
--
Alan Ford * [email protected]
On Tue, 2 Oct 2001 12:50:40 +0100 Alan Ford <[email protected]> wrote:
> - action_msg: "Emergency Remount R/0\n",
> + action_msg: "Emergency Remount R/O\n",
What exactly do you want to fix with this patch?
Regards,
Stephan
* Stephan von Krawczynski ([email protected]) wrote:
> On Tue, 2 Oct 2001 12:50:40 +0100 Alan Ford <[email protected]> wrote:
>
> > - action_msg: "Emergency Remount R/0\n",
> > + action_msg: "Emergency Remount R/O\n",
>
> What exactly do you want to fix with this patch?
That changes 'R/0' (R slash Zero) to R/O (R slash O).
I think 'Read-Only' is what is meant in this 'action_msg'
and is probably better represented with 'R/O' than 'R/0'.
Stephen
Stephan von Krawczynski <[email protected]> wrote:
> > - action_msg: "Emergency Remount R/0\n",
> > + action_msg: "Emergency Remount R/O\n",
>
> What exactly do you want to fix with this patch?
If you look closely you'll see that he changed '0' to 'O'.
--
Andr? Dahlqvist <[email protected]>
On Tue, 2 Oct 2001 08:53:27 -0400 Stephen Frost <[email protected]> wrote:
> * Stephan von Krawczynski ([email protected]) wrote:
> > On Tue, 2 Oct 2001 12:50:40 +0100 Alan Ford <[email protected]> wrote:
> >
> > > - action_msg: "Emergency Remount R/0\n",
> > > + action_msg: "Emergency Remount R/O\n",
> >
> > What exactly do you want to fix with this patch?
>
> That changes 'R/0' (R slash Zero) to R/O (R slash O).
> I think 'Read-Only' is what is meant in this 'action_msg'
> and is probably better represented with 'R/O' than 'R/0'.
Sorry for asking. I could not determine the difference in my on-screen font.
Regards,
Stephan
Stephan von Krawczynski wrote:
>
> On Tue, 2 Oct 2001 12:50:40 +0100 Alan Ford <[email protected]> wrote:
>
> > - action_msg: "Emergency Remount R/0\n",
> > + action_msg: "Emergency Remount R/O\n",
>
> What exactly do you want to fix with this patch?
Disclaimer: It ain't my patch :) .
But it looks like the old version used a "0" (zero) in R/O, and the new
version uses an "O" (oh).
> Regards,
> Stephan
Regards,
Josh