2001-10-11 08:06:06

by Linus Torvalds

[permalink] [raw]
Subject: Uhhuh.. 2.4.12


2.4.11 had a fix for a symlink DoS attack, but sadly that fix broke the
creation of files through a dangling symlink rather badly (it caused the
inode to be created in the very same inode as the symlink, with unhappy
end results).

Happily nobody uses that particular horror - or _almost_ nobody does. It
looks like at least the SuSE installer (yast2) does, which causes a nasty
unkillable inode as /dev/mouse if you use yast2 on 2.4.11.

("debugfs -w rootdev" + "rm /dev/mouse" will remove it, although I suspect
there are other less drastic methods too if your fsck doesn't seem to
notice anything wrong with it. Only one report of this actually happening
so far).

So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
2.4.11 was.

Linus

-----
final:
- Greg KH: USB update (fix UHCI timeouts, serial unplug)
- Christoph Rohland: shmem locking fixes
- Al Viro: more mount cleanup
- me: fix bad interaction with link_count handling
- David Miller: Sparc updates, net cleanup
- Tim Waugh: parport update
- Jeff Garzik: net driver updates


2001-10-11 08:41:11

by Tim Waugh

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

On Thu, Oct 11, 2001 at 08:30:52AM +0000, Linus Torvalds wrote:

> In article <[email protected]>,
> Linus Torvalds <[email protected]> wrote:
> >
> >So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
> >2.4.11 was.
> >
> > - Tim Waugh: parport update
>
> .. which is broken.
>
> Not a good week.

Here is the fix:

--- linux/drivers/parport/ieee1284_ops.c.orig Thu Oct 11 09:40:39 2001
+++ linux/drivers/parport/ieee1284_ops.c Thu Oct 11 09:40:42 2001
@@ -362,7 +362,7 @@
} else {
DPRINTK (KERN_DEBUG "%s: ECP direction: failed to reverse\n",
port->name);
- port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+ port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
}

return retval;
@@ -394,7 +394,7 @@
DPRINTK (KERN_DEBUG
"%s: ECP direction: failed to switch forward\n",
port->name);
- port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+ port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
}


Sorry guys. *blush*

Tim.
*/

2001-10-11 08:32:11

by Linus Torvalds

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

In article <[email protected]>,
Linus Torvalds <[email protected]> wrote:
>
>So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
>2.4.11 was.
>
> - Tim Waugh: parport update

.. which is broken.

Not a good week.

On the other hand, the good news is that I'll open 2.5.x RSN, just
because Alan is so much better at maintaining things ;)

Linus

2001-10-11 08:43:21

by Stefan Smietanowski

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

Hi.

>>So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
>>2.4.11 was.
>>
>> - Tim Waugh: parport update
>
> .. which is broken.
>
> Not a good week.
>
> On the other hand, the good news is that I'll open 2.5.x RSN, just
> because Alan is so much better at maintaining things ;)

Hmm. Does that mean that 2.4.x-ac will become the standard tree or ?
// Stefan



2001-10-11 08:50:12

by Tim Waugh

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

On Thu, Oct 11, 2001 at 10:42:09AM +0200, Stefan Smietanowski wrote:

> Hmm. Does that mean that 2.4.x-ac will become the standard tree or ?

No, it means that I have to write out 'I will not edit patches by hand
without testing them' a thousand times, _without_ using cut and
paste..

Tim.
*/


Attachments:
(No filename) (294.00 B)
(No filename) (232.00 B)
Download all attachments

2001-10-11 08:52:21

by Stefan Smietanowski

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

Hi.

>> Hmm. Does that mean that 2.4.x-ac will become the standard tree or ?
>
> No, it means that I have to write out 'I will not edit patches by hand
> without testing them' a thousand times, _without_ using cut and
> paste..

Wow. What a job. Why don't you code instead ? :)

// Stefan



2001-10-11 08:59:21

by J.A. Magallon

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12


On 20011011 Tim Waugh wrote:
>On Thu, Oct 11, 2001 at 08:30:52AM +0000, Linus Torvalds wrote:
>
>> In article <[email protected]>,
>> Linus Torvalds <[email protected]> wrote:
>> >
>> >So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
>> >2.4.11 was.
>> >
>> > - Tim Waugh: parport update
>>
>> .. which is broken.
>>
>> Not a good week.
>
>Here is the fix:
>
>--- linux/drivers/parport/ieee1284_ops.c.orig Thu Oct 11 09:40:39 2001
>+++ linux/drivers/parport/ieee1284_ops.c Thu Oct 11 09:40:42 2001
>@@ -362,7 +362,7 @@
> } else {
> DPRINTK (KERN_DEBUG "%s: ECP direction: failed to reverse\n",
> port->name);
>- port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
>+ port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
> }
>
> return retval;
>@@ -394,7 +394,7 @@
> DPRINTK (KERN_DEBUG
> "%s: ECP direction: failed to switch forward\n",
> port->name);
>- port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
>+ port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
> }
>

So you are on the work, why don't put out .13 ? And we have a correct tree...

--
J.A. Magallon # Let the source be with you...
mailto:[email protected]
Mandrake Linux release 8.2 (Cooker) for i586
Linux werewolf 2.4.10-ac11-beo #2 SMP Thu Oct 11 02:41:04 CEST 2001 i686

2001-10-11 10:16:38

by T. A.

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

Perhaps a quick update to the posted 2.4.12 kernel source tarball before
everyone downloads the bad one?

Or if its too late for that, 2.4.12a or 2.4.13? :-) (A new kernel version
out in only about an hour or so might beat the previous record.)

----- Original Message -----
From: "Tim Waugh" <[email protected]>
To: "Linus Torvalds" <[email protected]>
Cc: <[email protected]>
Sent: Thursday, October 11, 2001 4:41 AM
Subject: Re: Uhhuh.. 2.4.12


> On Thu, Oct 11, 2001 at 08:30:52AM +0000, Linus Torvalds wrote:
>
> > In article
<[email protected]>,
> > Linus Torvalds <[email protected]> wrote:
> > >
> > >So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
> > >2.4.11 was.
> > >
> > > - Tim Waugh: parport update
> >
> > .. which is broken.
> >
> > Not a good week.
>
> Here is the fix:
>
> --- linux/drivers/parport/ieee1284_ops.c.orig Thu Oct 11 09:40:39 2001
> +++ linux/drivers/parport/ieee1284_ops.c Thu Oct 11 09:40:42 2001
> @@ -362,7 +362,7 @@
> } else {
> DPRINTK (KERN_DEBUG "%s: ECP direction: failed to reverse\n",
> port->name);
> - port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
> + port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
> }
>
> return retval;
> @@ -394,7 +394,7 @@
> DPRINTK (KERN_DEBUG
> "%s: ECP direction: failed to switch forward\n",
> port->name);
> - port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
> + port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
> }
>
>
> Sorry guys. *blush*
>
> Tim.
> */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2001-10-11 11:35:43

by Marco Colombo

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

On Thu, 11 Oct 2001, Linus Torvalds wrote:

> In article <[email protected]>,
> Linus Torvalds <[email protected]> wrote:
> >
> >So I made a 2.4.12, and renamed away the sorry excuse for a kernel that
> >2.4.11 was.
> >
> > - Tim Waugh: parport update
>
> .. which is broken.
>
> Not a good week.
>
> On the other hand, the good news is that I'll open 2.5.x RSN, just
> because Alan is so much better at maintaining things ;)

And will Alan release 2.4.13 asap with Rik's VM? - (sorry, couldn't resist)

.TM.
--
____/ ____/ /
/ / / Marco Colombo
___/ ___ / / Technical Manager
/ / / ESI s.r.l.
_____/ _____/ _/ [email protected]

2001-10-11 11:49:23

by Alan

[permalink] [raw]
Subject: Re: Uhhuh.. 2.4.12

> > On the other hand, the good news is that I'll open 2.5.x RSN, just
> > because Alan is so much better at maintaining things ;)
>
> And will Alan release 2.4.13 asap with Rik's VM? - (sorry, couldn't resist)

I think 2.4.13 will be a Linus release