2001-11-01 00:01:15

by Stephen Rothwell

Subject: [PATCH] Stop APM readers from responding to events

Hi Linus,

This is just a small patch, but fills a hole. Thanks to Thomas Hood for a
patch.

Alan, This will also apply to 2.4.13-ac5.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

diff -ruN 2.4.14-pre5/arch/i386/kernel/apm.c 2.4.14-pre5-APM.1/arch/i386/kernel/apm.c
--- 2.4.14-pre5/arch/i386/kernel/apm.c Wed Oct 24 16:12:20 2001
+++ 2.4.14-pre5-APM.1/arch/i386/kernel/apm.c Thu Nov 1 01:09:48 2001
@@ -1471,7 +1471,7 @@
as = filp->private_data;
if (check_apm_user(as, "ioctl"))
return -EIO;
- if (!as->suser)
+ if ((!as->suser) || (!as->writer))
return -EPERM;
switch (cmd) {
case APM_IOC_STANDBY:

2001-11-01 00:50:24

by David Weinehall

Subject: Re: [PATCH] Stop APM readers from responding to events

On Thu, Nov 01, 2001 at 01:29:00AM +1100, Stephen Rothwell wrote:
> Hi Linus,
>
> This is just a small patch, but fills a hole. Thanks to Thomas Hood for a
> patch.
>
> Alan, This will also apply to 2.4.13-ac5.

Shouldn't this be done using capabilities instead?!

> diff -ruN 2.4.14-pre5/arch/i386/kernel/apm.c 2.4.14-pre5-APM.1/arch/i386/kernel/apm.c
> --- 2.4.14-pre5/arch/i386/kernel/apm.c Wed Oct 24 16:12:20 2001
> +++ 2.4.14-pre5-APM.1/arch/i386/kernel/apm.c Thu Nov 1 01:09:48 2001
> @@ -1471,7 +1471,7 @@
> as = filp->private_data;
> if (check_apm_user(as, "ioctl"))
> return -EIO;
> - if (!as->suser)
> + if ((!as->suser) || (!as->writer))
> return -EPERM;
> switch (cmd) {
> case APM_IOC_STANDBY:


/David Weinehall
_ _
// David Weinehall <[email protected]> /> Northern lights wander \\
// Project MCA Linux hacker // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </