-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
when compiling 2.5.1-pre2 I get the following error:
gcc -D__KERNEL__ -I/usr/src/linux-2.5.1-pre2/include -Wall
- -Wstrict-prototypes -Wno-trigraphs -O6 -fomit-frame-pointer
- -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
- -march=i686 -c -o ide-scsi.o ide-scsi.c
ide-scsi.c: In function `idescsi_dma_bio':
ide-scsi.c:710: request for member `bv_page' in something not a structure or
union
ide-scsi.c:711: request for member `bv_len' in something not a structure or
union
ide-scsi.c:712: request for member `bv_offset' in something not a structure
or union
ide-scsi.c:722: request for member `bv_page' in something not a structure or
union
ide-scsi.c:723: request for member `bv_len' in something not a structure or
union
ide-scsi.c:724: request for member `bv_offset' in something not a structure
or union
make[3]: *** [ide-scsi.o] Fehler 1
Attached you find my .config
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8A/FEvIHrJes3kVIRAvrkAKCF6Mb5u94gh/RRFGPh3fIVJSSoRwCfXoFG
qMZTi2TmOPbkXHEOtybW4og=
=DLk1
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
ok
I've corrected it myself I think
The patch is attached
Hopefully it doesn't break something :)
It's my first patch so please don't kill me
Bye
PS: sorry if/when you get this mail twice :(
My mail client is a bit confused today
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8A/xbvIHrJes3kVIRAoyxAJ4+XrCYXffS3P8zCmttT5WvkJ6w1QCdGpxK
nMof4o/n2VictCFrvZGRXeA=
=04xe
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I think the patch doesn't work :(
When I try to mount a CD over SCSI emulation I get this nice oops:
Unable to handle kernel NULL pointer dereference at virtual address 00000004
Nov 27 22:24:00 slomosnail kernel: printing eip:
Nov 27 22:24:00 slomosnail kernel: c01d0497
Nov 27 22:24:00 slomosnail kernel: *pde = 00000000
Nov 27 22:24:00 slomosnail kernel: Oops: 0000
Nov 27 22:24:00 slomosnail kernel: CPU: 0
Nov 27 22:24:00 slomosnail kernel: EIP: 0010:[idescsi_queue+1195/1508]
Not tainted
Nov 27 22:24:00 slomosnail kernel: EFLAGS: 00010046
Nov 27 22:24:00 slomosnail kernel: eax: 00000000 ebx: c14cfda0 ecx:
00000000 edx: c14cfda0
Nov 27 22:24:00 slomosnail kernel: esi: c0302000 edi: c14cfda0 ebp:
c14cfda0 esp: cc401e5c
Nov 27 22:24:00 slomosnail kernel: ds: 0018 es: 0018 ss: 0018
Nov 27 22:24:00 slomosnail kernel: Process mount (pid: 192,
stackpage=cc401000)
Nov 27 22:24:00 slomosnail kernel: Stack: 00000293 c15a5600 c15a5600 c15ba0c0
00000014 cc9b89a0 c15a5658 c0302000
Nov 27 22:24:00 slomosnail kernel: 00000000 00000000 cc6ca4c0 c15e12c0
c02fb2dc c01c582a c15a5600 c01ca8bc
Nov 27 22:24:00 slomosnail kernel: c02925c0 c15a5600 c01cd214 c15a56b8
00000000 c01cc434 c15a5600 c15a5600
Nov 27 22:24:00 slomosnail kernel: Call Trace: [scsi_dispatch_cmd+430/544]
[scsi_old_done+0/1852] [scsi_init_io_v+0/392] [scsi_request_fn+1420/1440]
[block_read_full_page+468/488]
Nov 27 22:24:00 slomosnail kernel: [generic_unplug_device+37/44]
[__run_task_queue+76/88] [block_sync_page+22/28] [___wait_on_page+101/140]
[do_generic_file_read+828/1172] [generic_file_read+129/308]
Nov 27 22:24:00 slomosnail kernel: [file_read_actor+0/92]
[sys_read+143/196] [system_call+51/56]
Nov 27 22:24:00 slomosnail kernel: Code: 8b 51 04 8b 46 04 8d 14 52 83 c1 10
89 04 91 8b 4f 1c 8b 46
After that the System is still responsible but a few minutes later I get this
in a endless loop:
scsi : aborting command due to timeout : pid 30, scsi0, channel 0, id 1, lun
0 0x28 00 00 00 00 00 00 00 02 00
I've tried
bh->bi_io_vec->bvl_vec[0].*
instead of
bh->bi_io_vec->bvl_vec->*
but I still get this errors
Maybe someone knows more... I don't
Bye
Am Dienstag, 27. November 2001 21:49 schrieb Sebastian Dr?ge:
> ok
> I've corrected it myself I think
> The patch is attached
> Hopefully it doesn't break something :)
> It's my first patch so please don't kill me
> Bye
>
> PS: sorry if/when you get this mail twice :(
> My mail client is a bit confused today
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BAeFvIHrJes3kVIRArcCAKCF51wrFnZ1RY+n2Qz2d6FhRti9LACgr/3G
ijxtXFVn7SqHc1XlDvEq0BA=
=ZqKg
-----END PGP SIGNATURE-----
Sebastian Dr?ge wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> ok
> I've corrected it myself I think
> The patch is attached
> Hopefully it doesn't break something :)
> It's my first patch so please don't kill me
> Bye
You patch is reverted and I don't think it will cut it,
since I tries this myself and it didn't work out.
BTW>. Anybody out there who managed to make
SCSI gogin on 2.5.1-pre2... I only have PPA ZIP and
IDE-SCSI at my home machine, and both fail with a bad
pointer derefference...
On Tue, Nov 27 2001, Slo Mo Snail wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I think the patch doesn't work :(
> When I try to mount a CD over SCSI emulation I get this nice oops:
Please try this patch, ide-scsi is over writing the io veclist (longer
story: the io_vec_list used to be embedded so memset'ing the bio would
be ok).
BTW, this could be handled smarter with the new scheme -- no need to
link the bio, more segments can be crammed into just one. Someone
playing around with making ide-scsi faster can do that though, I'm just
making it work :-)
kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.1-pre2/bio-pre2-2
--
Jens Axboe
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Jens,
your patch doesn't work for ide-scsi
I get this oops when trying to mount a CD:
Unable to handle kernel NULL pointer dereference at virtual address 00000000
printing eip:
c01cefff
*pde = 00000000
Oops: 0000
CPU: 0
EIP: 0010:[<c01cefff>] Tainted: P
EFLAGS: 00010202
eax: 00000004 ebx: 00000014 ecx: 00000001 edx: 00000000
esi: 00000000 edi: c02fe628 ebp: c02fe600 esp: cdda3d6c
ds: 0018 es: 0018 ss: 0018
Process mount (pid: 189, stackpage=cdda3000)
Stack: 00000800 c15b5600 00000010 00000004 00000000 00000000 c02fe628 c02fe200
00000000 00000400 00000000 c02fe000 c01cf22b c15b5600 00000800 c15b5600
c02908e0 c01cbaf0 c15b56b8 00000068 c01cb73a c15b5600 00000286 cdda3e0c
Call Trace: [<c01cf22b>] [<c01cbaf0>] [<c01cb73a>] [<c01b22c1>] [<c01199f0>]
[<c0134fb6>] [<c0134a71>] [<d099bc32>] [<c01cfdc1>] [<c0136458>]
[<d099fd84>] [<c0146fab>] [<c0136bfb>] [<d099fd84>] [<c0147d2a>]
[<c0147af4>] [<c014854c>] [<c0106b3b>]
Code: f3 a5 a8 02 74 02 66 a5 a8 01 74 01 a4 8b 54 24 34 0f b7 82
and this seems to be the same as with my patch
c01cefff seems to be sr_scatter_pad... because in System.map
there is: c01cee30 t sr_scatter_pad
it happens when I try to mount a CD. The drives are detected successfull
Maybe this helps you and when you need some more informations ask me
Bye
PS: I don't know why the tainted flag is set...
Only isofs and inflate_fs were loaded
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BO1RvIHrJes3kVIRApU9AJ4ydwvdiomS69lUKHB7nm8CXOzwtgCfR2+I
O1pxpk+ZdQ1J10KyW5YYvfU=
=Ew+a
-----END PGP SIGNATURE-----
On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Jens,
> your patch doesn't work for ide-scsi
> I get this oops when trying to mount a CD:
[oops in sr_scatter_pad]
Hmm ok, and 2.5.1-pre1 works for you right?
--
Jens Axboe
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hi Jens,
> > your patch doesn't work for ide-scsi
> > I get this oops when trying to mount a CD:
>
> [oops in sr_scatter_pad]
>
> Hmm ok, and 2.5.1-pre1 works for you right?
Yes it works very well
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BO7uvIHrJes3kVIRAs+IAJwMg9ru+joRHR9ei6Sqd6GzKMQ6ogCgmZ7X
1J8gTk2dC84QXU4g5Abp12M=
=dPWQ
-----END PGP SIGNATURE-----
On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Hi Jens,
> > > your patch doesn't work for ide-scsi
> > > I get this oops when trying to mount a CD:
> >
> > [oops in sr_scatter_pad]
> >
> > Hmm ok, and 2.5.1-pre1 works for you right?
>
> Yes it works very well
Ok, thanks for confirming that. Going to take a look at it now.
--
Jens Axboe
On Wed, Nov 28 2001, Jens Axboe wrote:
> On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > Hi Jens,
> > > > your patch doesn't work for ide-scsi
> > > > I get this oops when trying to mount a CD:
> > >
> > > [oops in sr_scatter_pad]
> > >
> > > Hmm ok, and 2.5.1-pre1 works for you right?
> >
> > Yes it works very well
>
> Ok, thanks for confirming that. Going to take a look at it now.
Does this work for you? Apply on top of what you already have.
--
Jens Axboe
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> On Wed, Nov 28 2001, Jens Axboe wrote:
> > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > Hi Jens,
> > > > > your patch doesn't work for ide-scsi
> > > > > I get this oops when trying to mount a CD:
> > > >
> > > > [oops in sr_scatter_pad]
> > > >
> > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > >
> > > Yes it works very well
> >
> > Ok, thanks for confirming that. Going to take a look at it now.
>
> Does this work for you? Apply on top of what you already have.
Yes it does work :)
Thank you very much
BTW my patch does work, too in addition with the sr-sg patch ;) But Jens' is
cleaner
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BPo7vIHrJes3kVIRAqtJAJ9zDUEC3hOr/YrhD0u9ffDq+0Qu/gCgkCFO
BZ/hoLNeJn69teIN8L1msSI=
=lXPv
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> On Wed, Nov 28 2001, Jens Axboe wrote:
> > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > Hi Jens,
> > > > > your patch doesn't work for ide-scsi
> > > > > I get this oops when trying to mount a CD:
> > > >
> > > > [oops in sr_scatter_pad]
> > > >
> > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > >
> > > Yes it works very well
> >
> > Ok, thanks for confirming that. Going to take a look at it now.
>
> Does this work for you? Apply on top of what you already have.
OK it does work BUT
when I read audio data from a CD it reads the first ~20 MB and then it
doesn't write anything on hdd.
When I try to play an audio CD with the KDE CD player it crashes immediately
2.5.1-pre1 works fine and mounting/reading data CDs work, too
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BjeSvIHrJes3kVIRAo8AAJsGac8MjYRteNLG7VU3eqJHacZAOACgrGqX
TfSiWC+4PeHJe08HFREgQy8=
=yOcb
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Donnerstag, 29. November 2001 14:26 schrieben Sie:
> Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> > On Wed, Nov 28 2001, Jens Axboe wrote:
> > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > > Hash: SHA1
> > > > > >
> > > > > > Hi Jens,
> > > > > > your patch doesn't work for ide-scsi
> > > > > > I get this oops when trying to mount a CD:
> > > > >
> > > > > [oops in sr_scatter_pad]
> > > > >
> > > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > > >
> > > > Yes it works very well
> > >
> > > Ok, thanks for confirming that. Going to take a look at it now.
> >
> > Does this work for you? Apply on top of what you already have.
>
> OK it does work BUT
> when I read audio data from a CD it reads the first ~20 MB and then it
> doesn't write anything on hdd.
> When I try to play an audio CD with the KDE CD player it crashes
> immediately 2.5.1-pre1 works fine and mounting/reading data CDs work, too
> Bye
But wait :)
I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio patch
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8Bjk4vIHrJes3kVIRAuLmAJ9wVsXe/S93b5in+3CyPl1QodIKPACeLtkx
qjsXfuO+dOOGPYoyyjgLfSE=
=lp5q
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Donnerstag, 29. November 2001 14:33 schrieben Sie:
> Am Donnerstag, 29. November 2001 14:26 schrieben Sie:
> > Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> > > On Wed, Nov 28 2001, Jens Axboe wrote:
> > > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > > > On Wed, Nov 28 2001, Sebastian Dr?ge wrote:
> > > > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > > > Hash: SHA1
> > > > > > >
> > > > > > > Hi Jens,
> > > > > > > your patch doesn't work for ide-scsi
> > > > > > > I get this oops when trying to mount a CD:
> > > > > >
> > > > > > [oops in sr_scatter_pad]
> > > > > >
> > > > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > > > >
> > > > > Yes it works very well
> > > >
> > > > Ok, thanks for confirming that. Going to take a look at it now.
> > >
> > > Does this work for you? Apply on top of what you already have.
> >
> > OK it does work BUT
> > when I read audio data from a CD it reads the first ~20 MB and then it
> > doesn't write anything on hdd.
> > When I try to play an audio CD with the KDE CD player it crashes
> > immediately 2.5.1-pre1 works fine and mounting/reading data CDs work, too
> > Bye
>
> But wait :)
> I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio
> patch Bye
Hmm it works :)
Thanks
I'll test some more things with my CD drives ;)
Maybe I'll find some bugs
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BkEEvIHrJes3kVIRAvQ9AKCbVMNKEbz3mB2XgFo8BKzymui5jQCdGJiF
KoBQHL2kW05Mjiw9lsQi3xc=
=Q1R3
-----END PGP SIGNATURE-----
On Thu, Nov 29 2001, Slo Mo Snail wrote:
> > But wait :)
> > I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio
> > patch Bye
> Hmm it works :)
Just to confirm -- 2.5.1-pre3 + Alan's patch + my bio-pre3-1 patch,
right? pre3 already contains the sg-sr part.
> I'll test some more things with my CD drives ;)
> Maybe I'll find some bugs
Please do :)
--
Jens Axboe
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Donnerstag, 29. November 2001 15:23 schrieben Sie:
> On Thu, Nov 29 2001, Slo Mo Snail wrote:
> > > But wait :)
> > > I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio
> > > patch Bye
> >
> > Hmm it works :)
>
> Just to confirm -- 2.5.1-pre3 + Alan's patch + my bio-pre3-1 patch,
> right? pre3 already contains the sg-sr part.
>
> > I'll test some more things with my CD drives ;)
> > Maybe I'll find some bugs
>
> Please do :)
Sorry my mistake
I've meant this patch:
http://kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.1-pre3/bio-pre3-1.gz
So it's 2.5.1-pre3 + Alan's patch + bio-pre3-1 + the patch you've posted
after the 2.5.1-pre3 don't-use mail
There were no failures while patching so I think this patches are compatible
each other ;)
And it works well... no data corruption, no oopses, no nothing ;)
Later the day I'll test burning a CD
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8BkgVvIHrJes3kVIRAiQQAKCG0efeie+bKhbKe+BHXaI4XCCSuACfS7T/
806yy00KSYP+zID3ijLskfQ=
=idKY
-----END PGP SIGNATURE-----
On Thu, Nov 29 2001, Sebastian Dr?ge wrote:
> Sorry my mistake
> I've meant this patch:
> http://kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.1-pre3/bio-pre3-1.gz
>
> So it's 2.5.1-pre3 + Alan's patch + bio-pre3-1 + the patch you've posted
> after the 2.5.1-pre3 don't-use mail
>
> There were no failures while patching so I think this patches are compatible
> each other ;)
Yes sure, that's what I expected. THe part I didn't understand was the
sr-sg-1 part.
> And it works well... no data corruption, no oopses, no nothing ;)
> Later the day I'll test burning a CD
Good
--
Jens Axboe