2001-12-02 16:30:30

by Matthias Andree

Subject: paride/Config.in and bool vs. mconfig 0.20

I tried to configure 2.4.17pre2 with mconfig 0.20, it said:

| drivers/block/paride/Config.in: 32: warning: bool command has extra
| arguments

And rightly so, bool wants the configuration question and the parameter,
nothing else.

Either that needs some dep_ stuff or it has indeed an extra argument, I
cannot decide which one is correct, so I'm not providing a patch now.

Would it be possible to fix this before 2.4.17 or 2.5.1 respectively?

--
Matthias Andree

"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety." Benjamin Franklin

2001-12-04 11:27:42

by Tim Waugh

Subject: [patch] Re: paride/Config.in and bool vs. mconfig 0.20

On Sun, Dec 02, 2001 at 05:29:57PM +0100, Matthias Andree wrote:

> I tried to configure 2.4.17pre2 with mconfig 0.20, it said:
>
> | drivers/block/paride/Config.in: 32: warning: bool command has extra
> | arguments
>
> And rightly so, bool wants the configuration question and the parameter,
> nothing else.
>
> Either that needs some dep_ stuff or it has indeed an extra argument, I
> cannot decide which one is correct, so I'm not providing a patch now.

That option really is just a bool. Here is the fix.

Tim.
*/

--- linux/drivers/block/paride/Config.in.bool Tue Dec 4 11:23:35 2001
+++ linux/drivers/block/paride/Config.in Tue Dec 4 11:24:17 2001
@@ -29,7 +29,7 @@
dep_tristate ' Shuttle EPAT/EPEZ protocol' CONFIG_PARIDE_EPAT $CONFIG_PARIDE
if [ "$CONFIG_PARIDE_EPAT" != "n" ]; then
if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
- bool ' Support c7/c8 chips (EXPERIMENTAL)' CONFIG_PARIDE_EPATC8 $CONFIG_PARIDE
+ bool ' Support c7/c8 chips (EXPERIMENTAL)' CONFIG_PARIDE_EPATC8
fi
fi