2001-12-04 17:04:56

by Stephen Cameron

Subject: cciss max SGs is 31, not 32, 2.5.1-pre5

Guys,

wrt 2.5.1-pre5

The change below should be reverted. The controller will reject a command
with 32 scatter gather entries.

Thanks,

-- steve

diff -u --recursive --new-file v2.5.0/linux/drivers/block/cciss_cmd.h
linux/drivers/block/cciss_cmd.h
--- v2.5.0/linux/drivers/block/cciss_cmd.h Fri Nov 2 17:45:42 2001
+++ linux/drivers/block/cciss_cmd.h Tue Nov 27 09:23:27 2001
@@ -7,7 +7,7 @@

//general boundary defintions
#define SENSEINFOBYTES 32//note that this value may vary between host implementations
-#define MAXSGENTRIES 31
+#define MAXSGENTRIES 32
#define MAXREPLYQS 256


__________________________________________________
Do You Yahoo!?
Buy the perfect holiday gifts at Yahoo! Shopping.
http://shopping.yahoo.com

2001-12-04 19:06:14

by Jens Axboe

Subject: Re: cciss max SGs is 31, not 32, 2.5.1-pre5

On Tue, Dec 04 2001, Stephen Cameron wrote:
> Guys,
>
> wrt 2.5.1-pre5
>
> The change below should be reverted. The controller will reject a command
> with 32 scatter gather entries.

Oops, probably my mistake. Funny thing is even tested this months ago
and came to the same conclusion (your docs are not that good...), I
guess it survived in the 2.5 tree because of lack of testing.

--
Jens Axboe