2001-12-06 17:51:36

by Ren

Subject: 2.4.17-pre2: unclean cleanup in i2ellis.c

Hi,

in 2.4.17-pre2 the definition of iiEllisCleanup() in
drivers/char/i2ellis.c got #if 0'd because it's unused. Problem is,
drivers/char/ip2main.c still calls this function in line 559.

Ren?

2001-12-06 17:53:23

by Marcelo Tosatti

Subject: Re: 2.4.17-pre2: unclean cleanup in i2ellis.c

Could you please send me a patch to undo that change ?

Thanks

On Thu, 6 Dec 2001, Ren? Scharfe wrote:

> Hi,
>
> in 2.4.17-pre2 the definition of iiEllisCleanup() in
> drivers/char/i2ellis.c got #if 0'd because it's unused. Problem is,
> drivers/char/ip2main.c still calls this function in line 559.
>
> Ren?
>

2001-12-06 19:07:23

by Ren

Subject: Re: 2.4.17-pre2: unclean cleanup in i2ellis.c

> Could you please send me a patch to undo that change ?

Sure.

--- linux-2.4.17-pre2/drivers/char/ip2/i2ellis.c Thu Dec 6 19:38:02 2001
+++ linux-2.4.17-pre1/drivers/char/ip2/i2ellis.c Wed Oct 24 21:05:18 2001
@@ -102,7 +102,6 @@
// This routine performs any required cleanup of the iiEllis subsystem.
//
//******************************************************************************
-#if 0 /* Unused */
static void
iiEllisCleanup(void)
{
@@ -110,7 +109,6 @@
kfree ( pDelayTimer );
}
}
-#endif

//******************************************************************************
// Function: iiSetAddress(pB, address, delay)