2001-12-07 10:22:06

by Andris Pavenis

[permalink] [raw]
Subject: i810_audio.c v0.11 is still broken (deadlocks)

Downloaded i810_audio.c v0.11 this morning.

After loading it I'm getting system deadlock immediatelly after first attempt
to use sound support as i810_write() calls i810_update_lvi() without setting
PCM_ENABLE_INPUT bit. Added setting this bit in i810_write() and
also some protection against deadlocks in __i810_update_lvi() with
corresponding error message (see attached diffs).

Results: sound seems to work as far as I have tested for not a very long time.

I'm still getting messages that __i810_update_lvi() is called without setting
PCM_ENABLE_INPUT (which would cause deadlock without protection
I added there).

Andris


Attachments:
i810_audio.c.diff (856.00 B)

2001-12-07 13:08:02

by Andris Pavenis

[permalink] [raw]
Subject: Re: i810_audio.c v0.11 is still broken (deadlocks)

On Friday 07 December 2001 12:21, Andris Pavenis wrote:
> Downloaded i810_audio.c v0.11 this morning.
>
> After loading it I'm getting system deadlock immediatelly after first
> attempt to use sound support as i810_write() calls i810_update_lvi()
> without setting PCM_ENABLE_INPUT bit. Added setting this bit in
> i810_write() and
> also some protection against deadlocks in __i810_update_lvi() with
> corresponding error message (see attached diffs).
>
> Results: sound seems to work as far as I have tested for not a very long
> time.
>
> I'm still getting messages that __i810_update_lvi() is called without
> setting PCM_ENABLE_INPUT (which would cause deadlock without protection
> I added there).

My previous patch was incorrect

Here is updated version of the patch against i810_audio.c v 0.11 (from
http://people.redhat.com/dledford/i810_audio.c.gz), which seems to work for
me. I still left in debugging output.

Andris


Attachments:
i810_audio.c.diff2 (3.11 kB)