2001-12-08 06:10:18

by Adam J. Richter

[permalink] [raw]
Subject: Patch?: linux-2.5.1-pre7/drivers/block/xd.c compilation fixes

I do not know the whole new block IO interface, but here
is my attempt at making linux-2.4.17-pre7/drivers/block/xd.c compile.
If I got any of this wrong, I would appreciate someone telling me,
because I may start tring to fix some of the other 90+ drivers that
do not compile in 2.4.1-pre7 later this weekend.

--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
[email protected] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."


Attachments:
(No filename) (602.00 B)
xd.patch (1.20 kB)
Download all attachments

2001-12-08 09:06:58

by Jens Axboe

[permalink] [raw]
Subject: Re: Patch?: linux-2.5.1-pre7/drivers/block/xd.c compilation fixes

On Fri, Dec 07 2001, Adam J. Richter wrote:
> I do not know the whole new block IO interface, but here
> is my attempt at making linux-2.4.17-pre7/drivers/block/xd.c compile.
> If I got any of this wrong, I would appreciate someone telling me,
> because I may start tring to fix some of the other 90+ drivers that
> do not compile in 2.4.1-pre7 later this weekend.

That would be great! The fix looks good -- what you want to add in
addition is checking that this is a rw request. So before your switch,
do something ala

/*
* we don't support special requests
*/
if (!(CURRENT->flags & REQ_CMD)) {
blkdev_dequeue_request(CURRENT);
end_that_request_first(CURRENT, 0, CURRENT->nr_sectors);
end_that_request_last(CURRENT);
continue;
}

--
Jens Axboe