2001-12-27 16:06:24

by Anders Gustafsson

Subject: kiB

this shouldn't be that controversial, as it's only visible to people
compiling kernels :)

--

//anders/g

diff -ru linux-2.5.2-pre2/arch/i386/boot/tools/build.c linux-2.5.2-pre2-lvmfix/arch/i386/boot/tools/build.c
--- linux-2.5.2-pre2/arch/i386/boot/tools/build.c Mon Jul 2 22:56:40 2001
+++ linux-2.5.2-pre2-lvmfix/arch/i386/boot/tools/build.c Thu Dec 27 16:48:55 2001
@@ -148,7 +148,7 @@
if (fstat (fd, &sb))
die("Unable to stat `%s': %m", argv[3]);
sz = sb.st_size;
- fprintf (stderr, "System is %d kB\n", sz/1024);
+ fprintf (stderr, "System is %d kiB\n", sz/1024);
sys_size = (sz + 15) / 16;
/* 0x28000*16 = 2.5 MB, conservative estimate for the current maximum */
if (sys_size > (is_big_kernel ? 0x28000 : DEF_SYSSIZE))

2001-12-27 16:14:52

by Martin Jonsson

Subject: Re: kiB

[email protected] wrote:

> this shouldn't be that controversial, as it's only visible to people
> compiling kernels :)
>
> --
>
> //anders/g
>
> diff -ru linux-2.5.2-pre2/arch/i386/boot/tools/build.c
> linux-2.5.2-pre2-lvmfix/arch/i386/boot/tools/build.c
> --- linux-2.5.2-pre2/arch/i386/boot/tools/build.c Mon Jul 2
> 22:56:40 2001
> +++ linux-2.5.2-pre2-lvmfix/arch/i386/boot/tools/build.c Thu Dec
> 27
> 16:48:55 2001
> @@ -148,7 +148,7 @@
> if (fstat (fd, &sb))
> die("Unable to stat `%s': %m", argv[3]);
> sz = sb.st_size;
> - fprintf (stderr, "System is %d kB\n", sz/1024);
> + fprintf (stderr, "System is %d kiB\n", sz/1024);

Shouldn't that be "KiB" when talking about kibibytes?

> sys_size = (sz + 15) / 16;
> /* 0x28000*16 = 2.5 MB, conservative estimate for the current
> maximum */
> if (sys_size > (is_big_kernel ? 0x28000 : DEF_SYSSIZE))

--
/marty

2001-12-27 16:18:52

by Anders Gustafsson

Subject: Re: kiB

On Thu, Dec 27, 2001 at 05:14:25PM +0100, Martin Jonsson wrote:
> > - fprintf (stderr, "System is %d kB\n", sz/1024);
> > + fprintf (stderr, "System is %d kiB\n", sz/1024);
>
> Shouldn't that be "KiB" when talking about kibibytes?

yes, ofcourse.. new patch attached :)

--

//anders/g

diff -ru linux-2.5.2-pre2/arch/i386/boot/tools/build.c linux-2.5.2-pre2-lvmfix/arch/i386/boot/tools/build.c
--- linux-2.5.2-pre2/arch/i386/boot/tools/build.c Mon Jul 2 22:56:40 2001
+++ linux-2.5.2-pre2-lvmfix/arch/i386/boot/tools/build.c Thu Dec 27 17:13:20 2001
@@ -148,7 +148,7 @@
if (fstat (fd, &sb))
die("Unable to stat `%s': %m", argv[3]);
sz = sb.st_size;
- fprintf (stderr, "System is %d kB\n", sz/1024);
+ fprintf (stderr, "System is %d KiB\n", sz/1024);
sys_size = (sz + 15) / 16;
/* 0x28000*16 = 2.5 MB, conservative estimate for the current maximum */
if (sys_size > (is_big_kernel ? 0x28000 : DEF_SYSSIZE))

2001-12-27 22:31:40

by Guest section DW

Subject: Re: kiB

On Thu, Dec 27, 2001 at 05:05:57PM +0100, [email protected] wrote:
> this shouldn't be that controversial, as it's only visible to people
> compiling kernels :)

> + fprintf (stderr, "System is %d kiB\n", sz/1024);

But if you want to change things to conform, do so.
The unit is Ki, not ki.