2002-01-05 10:50:58

by Adam J. Richter

[permalink] [raw]
Subject: Patch: linux-2.5.2-pre8/drivers/mtd compilation fixes

The following patch updates linux-2.5.2-pre8/drivers/mtd
to compile. This entails some kdev_t fixes and other updates
for changes to the block device driver interface.

In the case of one routine (ftl_reread_partitions), there was
a goto to a nonexistant label (goto leave), so I think there may have
been an incomplete patch applied to this subdirectory to begin with
(also, drivers/mtd/bootldr.c refers to a nonexistant "struct tag",
but that file is apparently not currently compiled anyhow).

I only know that this patch makes the code compile. I
have not tested it.

--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
[email protected] \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."


Attachments:
(No filename) (866.00 B)
mtd.diffs (17.38 kB)
Download all attachments

2002-01-05 11:24:58

by David Woodhouse

[permalink] [raw]
Subject: Re: Patch: linux-2.5.2-pre8/drivers/mtd compilation fixes


[email protected] said:
> The following patch updates linux-2.5.2-pre8/drivers/mtd to compile.
> This entails some kdev_t fixes and other updates for changes to the
> block device driver interface.

Looks sane - thanks. I see no harm in sending it to Linus. Could you run
the blkmtd.c changes past [email protected] first, though?

> In the case of one routine (ftl_reread_partitions), there was a goto
> to a nonexistant label (goto leave), so I think there may have been an
> incomplete patch applied to this subdirectory to begin with

Not in my tree - strange. Oh well, I'll deal with it when 2.5 stabilises
and I stop ignoring it.

> (also, drivers/mtd/bootldr.c refers to a nonexistant "struct tag", but that
> file is apparently not currently compiled anyhow).

Currently, it's only compiled in the iPAQ kernel tree, where it works - I'm
waiting for the iPAQ people and Russell to stop arguing about how it should
be done, so the result will work in the proper ARM tree (and hence Linus'
tree) too.

Btw, where did you get the address '[email protected]' from? The list moved
a while ago, and I was going to remove the forwarding some time soon.

--
dwmw2


2002-01-05 12:42:48

by Russell King

[permalink] [raw]
Subject: Re: Patch: linux-2.5.2-pre8/drivers/mtd compilation fixes

On Sat, Jan 05, 2002 at 11:24:23AM +0000, David Woodhouse wrote:
> Currently, it's only compiled in the iPAQ kernel tree, where it works - I'm
> waiting for the iPAQ people and Russell to stop arguing about how it should
> be done, so the result will work in the proper ARM tree (and hence Linus'
> tree) too.

I don't see this ever being solved.

Basically, the iPAQ people are quite happy to ignore concerns of the
non-iPAQ community to the point of ignoring any and all discussion
about it for months on end, so I'm happy to not merge the stuff until
they've addressed our concerns.

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html