Hello,
In the process of compiling ALSA for my new 2.5.2pre10 kernel I noticed
that MINOR(inode->i_rdev) causes compile errors and should be replaced
with minor(inode->i_rdev) Looking at a number of the OSS sound drivers
in the kernel I noticed that they to would not compile in 2.5.2pre10 (eg
Turtle Beach Pinnacle) I fixed all of these modules and a patch is
attached. However, looking further I noticed that there were similar
problems in a number of other drivers. Before I undertook cleaning all
of them I thought I would check in and make sure I was doing the right
thing. Namely that every instance of MINOR(inode->i_rdev) or
MINOR(i_rdev) should be replaced with minor(inode->i_rdev) or
minor(i_rdev).
Please CC me on any replies since I am not subscribed to the list.
Thanks,
Brendan
On 09 Jan 2002 14:20:23 -0500
Brendan Burns <[email protected]> wrote:
> Hello,
Hello!
> In the process of compiling ALSA for my new 2.5.2pre10 kernel I noticed
> that MINOR(inode->i_rdev) causes compile errors and should be replaced
> with minor(inode->i_rdev) Looking at a number of the OSS sound drivers
> in the kernel I noticed that they to would not compile in 2.5.2pre10 (eg
> Turtle Beach Pinnacle) I fixed all of these modules and a patch is
> attached. However, looking further I noticed that there were similar
> problems in a number of other drivers. Before I undertook cleaning all
> of them I thought I would check in and make sure I was doing the right
> thing. Namely that every instance of MINOR(inode->i_rdev) or
> MINOR(i_rdev) should be replaced with minor(inode->i_rdev) or
> minor(i_rdev).
I've contributed patch for emu10k1, because tests after 'MINOR' replacement successed. You're on the right way.
Regards.
--
Nikita Gergel System Administrator
Moscow, Russia YAUZA-Telecom